Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

283 update lightning to fix critical alert #284

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

jashapiro
Copy link
Member

Closes #283
The main goal here was to update lightning to include the security fix, but I also updated the requirements script to better deal with updating python packages (I would otherwise have to delete the files and recreate them every time).

I also added an extra bit to the version string for ~= dependencies to freeze them at the minor version level; I had misunderstood the syntax to freeze at the given level, but it actually does the level above. A ~=1.1string will allow updates to version1.1.x, 1.2.xor generally1.y.x, but if we specify ~=1.1.1, it will only update to 1.1.x`, which is what we likely want.

The package changes seem to be mostly low-level; I don't expect significant effects, but we will want to test these at least in part before a new release of scpcaTools and incorporation into scpca-nf.

Copy link
Member

@jaclyn-taroni jaclyn-taroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@jashapiro jashapiro merged commit 3cd4b2a into main Oct 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update lightning to fix critical alert
2 participants