Removed the capitalization of expectedArgs #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This example errors out when `expectedArgs` are capitalized as noted in this [discord thread](https://discord.com/channels/464316540490088448/818363058656509993/848026674183798825). Example or Error from the [current master branch](baa1d9e): ```bash (node:57462) UnhandledPromiseRejectionWarning: DiscordAPIError: Invalid Form Body options[0].name: Command name is invalid options[1].name: Command name is invalid options[2].name: Command name is invalid at RequestHandler.execute (/Users/gndclouds/Downloads/Worn-Off-Keys-Discord-Js-master/82-Slash-Commands/82-Slash-Commands/node_modules/discord.js/src/rest/RequestHandler.js:154:13) at processTicksAndRejections (internal/process/task_queues.js:97:5) at async RequestHandler.push (/Users/gndclouds/Downloads/Worn-Off-Keys-Discord-Js-master/82-Slash-Commands/82-Slash-Commands/node_modules/discord.js/src/rest/RequestHandler.js:39:14) (node:57462) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1) (node:57462) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This example errors out when
expectedArgsare capitalized as noted in this discord thread.Example or Error from the current master branch:
(node:57462) UnhandledPromiseRejectionWarning: DiscordAPIError: Invalid Form Body options[0].name: Command name is invalid options[1].name: Command name is invalid options[2].name: Command name is invalid at RequestHandler.execute (/Users/gndclouds/Downloads/Worn-Off-Keys-Discord-Js-master/82-Slash-Commands/82-Slash-Commands/node_modules/discord.js/src/rest/RequestHandler.js:154:13) at processTicksAndRejections (internal/process/task_queues.js:97:5) at async RequestHandler.push (/Users/gndclouds/Downloads/Worn-Off-Keys-Discord-Js-master/82-Slash-Commands/82-Slash-Commands/node_modules/discord.js/src/rest/RequestHandler.js:39:14) (node:57462) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1) (node:57462) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.