Skip to content

Commit

Permalink
keep consistent in naming
Browse files Browse the repository at this point in the history
  • Loading branch information
alxgomz committed Sep 18, 2023
1 parent 74256d0 commit 6557f1b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/actions/setup-kind/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ inputs:
https://github.com/kubernetes-sigs/kind/releases
required: true
default: kindest/node:v1.24.7@sha256:577c630ce8e509131eab1aea12c022190978dd2f745aac5eb1fe65c0807eb315
nginx-ingress-ref:
ingress-nginx-ref:
description: |
the Nginx ingress ref to get the ingress congtroller deployment manifest from
(https://github.com/kubernetes/ingress-nginx). Consider main (the default) a floating tag which can result in
Expand All @@ -28,7 +28,7 @@ runs:
shell: bash
env:
NGINX_MANIFEST_URL: >-
https://raw.githubusercontent.com/kubernetes/ingress-nginx/${{ inputs.nginx-ingress-ref }}/deploy/static/provider/kind/deploy.yaml
https://raw.githubusercontent.com/kubernetes/ingress-nginx/${{ inputs.ingress-nginx-ref }}/deploy/static/provider/kind/deploy.yaml
run: |
kubectl apply -f "${NGINX_MANIFEST_URL}"
Expand Down
4 changes: 2 additions & 2 deletions docs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -1179,14 +1179,14 @@ Spin up a local kubernetes cluster with nginx ingress exposing http/https ports.
with:
# See the available refs in the kind release notes at https://github.com/kubernetes-sigs/kind/releases
# kind-node-image: kindest/node:v1.24.7@sha256:577c630ce8e509131eab1aea12c022190978dd2f745aac5eb1fe65c0807eb315
nginx-ingress-ref: controller-v1.8.2
ingress-nginx-ref: controller-v1.8.2
- name: Helm deploy
run: |
helm dep up ./helm/chart
helm install acs ./helm/chart
```

> Although not required we recommend setting the `nginx-ingress-ref``to ensure repeatable builds
> Although not required we recommend setting the `ingress-nginx-ref``to ensure repeatable builds

### update-project-base-tag

Expand Down

0 comments on commit 6557f1b

Please sign in to comment.