AAE-15944: allow specifying nginx manifest in setup-kind #309
Conversation
| run: | | ||
| kubectl apply -f $NGINX_MANIFEST | ||
| kubectl apply -f ${{ inputs.nginx-manifest }} |
There was a problem hiding this comment.
how do you plan to use it? (link a PR)
I think there are very few situations where we need to completely provide a custom nginx install manifest, while the most common use case will be to install a specific ingress-nginx version - so providing an input to customize the current /main/ subpath should be enough?
There was a problem hiding this comment.
I did not validate if changing the version would be enough: I'll set that work aside for now then
There was a problem hiding this comment.
I actually just faced a use case where that would have been useful as a setting has been changed one hour ago and it would have been useful to be able to pin the version
There was a problem hiding this comment.
To add on top of Gio's comment I would add that if changing the version would not be enough one can still patch the deployment manually as he needs to in a different tasks. If you don't min I'll take over this PR and amend to turn nginx-manifest input to a nginx-igress-ref?
There was a problem hiding this comment.
This PR is just a draft but feel free to reuse it: as I said above I did not validate the changes for which this would have been useful.
Also as discussed with @gionn the input does not need to be the whole URL, it could be controlling the "main" part in the URL only
There was a problem hiding this comment.
yes @alxgomz please go ahead (and FYI my dependent unsuccessful PR is/was Activiti/activiti-cloud#1165)
atchertchian
changed the title
|
done with #326 --> resolve |
Checklist
Description