Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAE-17459 Moved GitHub actions from alfresco-process to this repo #338

Merged
merged 16 commits into from
Oct 26, 2023

Conversation

gicappa
Copy link
Contributor

@gicappa gicappa commented Oct 25, 2023

Checklist

  • Jira Reference (also in PR title): AAE-17459
  • README updated after adding/changing behaviour of an action
  • Proposed version increment for release:
    • Patch (bugfix)
    • Minor (new feature)
    • Major (breaking changes)
  • External PR link where changes has been tested:

Description

The two actions docker-build-image and docker-scan-image have been created in the Alfresco/alfresco-process repository. This was causing a bad coupling between the action changes in the alfresco-process repo and the other repos containing the action (like Alfresco/alfresco-deployment-service).

Moving to here the action enable a better decoupled design.

Refs: AAE-17459

The two actions docker-build-image and docker-scan-image have been
created in the Alfresco/alfresco-process repository.
This was causing a bad coupling between the action changes in the
alfresco-process repo and the other repos containing the action
(like Alfresco/alfresco-deployment-service).

Moving to here the action enable a better decoupled design.

Refs: AAE-17459
@gicappa gicappa changed the title Moved GitHub actions from alfresco-process to this repo AAE-17459 Moved GitHub actions from alfresco-process to this repo Oct 25, 2023
@gicappa gicappa force-pushed the AAE-17459-move-grype-actions-to-build-tools branch from 24bfdf1 to de8c713 Compare October 25, 2023 17:36
@gicappa gicappa marked this pull request as ready for review October 25, 2023 17:42
@gicappa gicappa requested a review from a team as a code owner October 25, 2023 17:42
Copy link
Contributor

@atchertchian atchertchian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I requested a few changes, please have a look at comments

.github/actions/docker-build-image/action.yml Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Show resolved Hide resolved
.github/actions/docker-build-image/action.yml Outdated Show resolved Hide resolved
.github/actions/docker-build-image/action.yml Outdated Show resolved Hide resolved
.github/actions/docker-build-image/action.yml Outdated Show resolved Hide resolved
.github/actions/docker-build-image/action.yml Outdated Show resolved Hide resolved
.github/actions/docker-build-image/action.yml Outdated Show resolved Hide resolved
gicappa and others added 10 commits October 26, 2023 15:51
The file copied from alfresco-process repo has a new version and needs to be
updated before being moved.

Refs: AAE-17459
Co-authored-by: Anahide Tchertchian <[email protected]>
Co-authored-by: Anahide Tchertchian <[email protected]>
Co-authored-by: Anahide Tchertchian <[email protected]>
Co-authored-by: Anahide Tchertchian <[email protected]>
@gicappa gicappa requested a review from mteodori October 26, 2023 15:11
@gicappa gicappa merged commit 6ed7a42 into master Oct 26, 2023
2 checks passed
@gicappa gicappa deleted the AAE-17459-move-grype-actions-to-build-tools branch October 26, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants