-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AAE-17459 Moved GitHub actions from alfresco-process to this repo #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The two actions docker-build-image and docker-scan-image have been created in the Alfresco/alfresco-process repository. This was causing a bad coupling between the action changes in the alfresco-process repo and the other repos containing the action (like Alfresco/alfresco-deployment-service). Moving to here the action enable a better decoupled design. Refs: AAE-17459
gicappa
changed the title
Moved GitHub actions from alfresco-process to this repo
AAE-17459 Moved GitHub actions from alfresco-process to this repo
Oct 25, 2023
Basic documentation for the two actions. Needs to be improved. Refs: AAE-17459
gicappa
force-pushed
the
AAE-17459-move-grype-actions-to-build-tools
branch
from
October 25, 2023 17:36
24bfdf1
to
de8c713
Compare
gicappa
requested review from
mteodori,
atchertchian,
eromano and
andrea-ligios
October 25, 2023 17:42
mteodori
approved these changes
Oct 25, 2023
eromano
approved these changes
Oct 26, 2023
atchertchian
requested changes
Oct 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I requested a few changes, please have a look at comments
The file copied from alfresco-process repo has a new version and needs to be updated before being moved. Refs: AAE-17459
Co-authored-by: Anahide Tchertchian <[email protected]>
Co-authored-by: Anahide Tchertchian <[email protected]>
Co-authored-by: Anahide Tchertchian <[email protected]>
Co-authored-by: Anahide Tchertchian <[email protected]>
Co-authored-by: Anahide Tchertchian <[email protected]>
Co-authored-by: Anahide Tchertchian <[email protected]>
Co-authored-by: Anahide Tchertchian <[email protected]>
Co-authored-by: Anahide Tchertchian <[email protected]>
atchertchian
approved these changes
Oct 26, 2023
mteodori
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
The two actions docker-build-image and docker-scan-image have been created in the Alfresco/alfresco-process repository. This was causing a bad coupling between the action changes in the alfresco-process repo and the other repos containing the action (like Alfresco/alfresco-deployment-service).
Moving to here the action enable a better decoupled design.
Refs: AAE-17459