Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACS-6300 Add a static-name flag for reportportal-prepare action #386

Merged

Conversation

wojtekswieton
Copy link
Contributor

No description provided.

Copy link

@MichalFidor MichalFidor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

.github/actions/reportportal-prepare/action.yml Outdated Show resolved Hide resolved
.github/actions/reportportal-prepare/action.yml Outdated Show resolved Hide resolved
.github/actions/reportportal-prepare/action.yml Outdated Show resolved Hide resolved
.github/actions/reportportal-prepare/get-rp-input.sh Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
@dsibilio
Copy link
Contributor

Few test failures here need to be looked at and addressed.

Copy link
Contributor

@dsibilio dsibilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.github/actions/reportportal-prepare/action.yml Outdated Show resolved Hide resolved
.github/actions/reportportal-prepare/action.yml Outdated Show resolved Hide resolved
.github/actions/reportportal-prepare/get-rp-input.sh Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@dsibilio dsibilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️

Please, next time don't delete the PR template but fill it appropriately. It's there for a reason 👍

@atchertchian thank you very much for your help!

Copy link
Member

@gionn gionn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, next time don't delete the PR template but fill it appropriately. It's there for a reason 👍

@gionn gionn merged commit 3b6fc84 into master Nov 27, 2023
3 checks passed
@gionn gionn deleted the feature/ACS-6300_Prepeare_Report_Portal_Static_Launch_Name branch November 27, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants