Aae 17274 clean up docker-build-image after switching to OIDC to push to ECR
#387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These inputs are no longer needed after switching to OIDC
erdemedeiros
requested review from
atchertchian,
andrea-ligios,
matteo4diani,
graric and
RahulKumar1606
erdemedeiros
changed the title
docker-build-image after switching to OIDC to push to ECR
graric
approved these changes
Nov 24, 2023
eromano
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Remove the possibility of connecting to AWS using access key id and secret access key for the action
docker-build-image. All the current usages of this action are going to use OIDC, so onlyaws-account-id,aws-role-nameandaws-regionare needed.