Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPSEXP-2801: refactor and bugfix of dbp-charts/verify-compose action #761

Merged
merged 5 commits into from
Oct 3, 2024
Merged

OPSEXP-2801: refactor and bugfix of dbp-charts/verify-compose action #761

merged 5 commits into from
Oct 3, 2024

Conversation

alxgomz
Copy link
Contributor

@alxgomz alxgomz commented Oct 2, 2024

Checklist

Description

  • Refactor to minimize dup & get logs on compose errors
  • Fix compose failing when no docker-compose.yml is present
  • Do not wait for Solr is ACS is not configured to use it as a search backend

@alxgomz alxgomz requested a review from a team as a code owner October 2, 2024 17:08
@alxgomz alxgomz mentioned this pull request Oct 2, 2024
Merged
pmacius
pmacius reviewed Oct 3, 2024
View reviewed changes
.github/actions/dbp-charts/verify-compose/docker_compose.sh Outdated
@@ -5,6 +5,26 @@ COMPOSE_PATH=$(dirname $COMPOSE_FILE_PATH)
COMPOSE_BIN="docker compose"
alf_port=8080

containers_dump_logs_on_error() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use different name - is it only dumping logs when on error?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed not, it's only being called on errors in the script XD

@alxgomz alxgomz requested a review from pmacius October 3, 2024 08:53
@alxgomz alxgomz merged commit 30177f8 into master Oct 3, 2024
3 checks passed
@alxgomz alxgomz deleted the OPSEXP-2801 branch October 3, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmacius pmacius pmacius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alxgomz @pmacius