AAE-28530 Teams notifications improvements #826
Conversation
- move to adaptative cards for send-teams-notification-action: unused input "overwrite" was removed - add markdown message support for teams usage from reportportal-summarize
There was a problem hiding this comment.
these screenshots looks like using the deprecated webhooks and not the workflows based ones - is this intentional?
There was a problem hiding this comment.
I did not change that part: I tested with a workflow hook and it did not work ok so I set this aside for now
| if [ -n "$COMPUTED_MESSAGE" ]; then | ||
| COMPUTED_MESSAGE="${COMPUTED_MESSAGE}" | ||
| COMPUTED_MESSAGE=$(printf "${COMPUTED_MESSAGE}" | sed -z 's/\n/\\n/g' | sed -r 's/"/\\\"/g' | sed -e 's/\r//g') | ||
| # avoid error if message is too long (total message must be less than 3001 characters) |
There was a problem hiding this comment.
Teams limit for messages is ~28KB for both channels and chats.
We could consider either:
- raising this limit
- rewording the comment to reflect that it's just our preference to cut it down to 3k chars for now
There was a problem hiding this comment.
Actually this particular number was added when some slack limits were hit: we can definitely up this limit but it does feel like it's enough content (especially since the long content usually comes from long commit messages, so we can always get the full info even if it's not in the notif)
| - name: Send teams notification | ||
| uses: skitionek/notify-microsoft-teams@9c67757f64d610fb6748d8ff3c11f284355ed7ec # v1.0.8 | ||
| uses: skitionek/notify-microsoft-teams@190d4d92146df11f854709774a4dae6eaf5e2aa3 # master |
There was a problem hiding this comment.
I'm a bit concerned about the state of this repository, it's not great with 2 commits and no releases in the last year lol
There was a problem hiding this comment.
Same, now I think we can always change and use another action if that's better
|  | ||
|
|
||
| Sample of a FAILURE notification on a `push` event. | ||
|  |
There was a problem hiding this comment.
The docs here mentioned creating the hook via the "Incoming Webhook" approach that is going to be deprecated by MSFT soon.
I was curious whether we tried at all the new approach based on Workflows after the changes? It'd be great to avoid having to rework this in the near future 😅
There was a problem hiding this comment.
I was thinking we could try again when the notifs are up: as I told you in chat I had a quick try and it did not work, if it does it's just a matter of updating the Readme doc
Checklist
Description