[MNT-24127] Added Endpoint To Calculate Folder Size #2709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohit-singh4
requested review from
suneet-gupta,
kavitshah-gl,
code4uuuu and
SathishK-T
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
PMD found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
remote-api/src/main/java/org/alfresco/rest/api/nodes/NodeFolderSizeRelation.java
Fixed
Show fixed
Hide fixed
remote-api/src/main/java/org/alfresco/rest/api/nodes/NodeFolderSizeRelation.java
Fixed
Show fixed
Hide fixed
remote-api/src/main/java/org/alfresco/rest/api/nodes/NodeFolderSizeRelation.java
Fixed
Show fixed
Hide fixed
repository/src/main/java/org/alfresco/repo/action/executer/NodeSizeActionExecuter.java
Fixed
Show fixed
Hide fixed
remote-api/src/test/java/org/alfresco/rest/api/tests/NodeFolderSizeApiTest.java
Fixed
Show fixed
Hide fixed
repository/src/main/java/org/alfresco/repo/action/executer/NodeSizeActionExecuter.java
Fixed
Show fixed
Hide fixed
repository/src/main/java/org/alfresco/repo/action/executer/NodeSizeActionExecuter.java
Fixed
Show fixed
Hide fixed
remote-api/src/main/java/org/alfresco/rest/api/nodes/NodeFolderSizeRelation.java
Fixed
Show fixed
Hide fixed
remote-api/src/test/java/org/alfresco/rest/api/tests/NodeFolderSizeApiTest.java
Fixed
Show fixed
Hide fixed
remote-api/src/test/java/org/alfresco/rest/api/tests/NodeFolderSizeApiTest.java
Fixed
Show fixed
Hide fixed
repository/src/main/java/org/alfresco/repo/action/executer/NodeSizeActionExecuter.java
Fixed
Show fixed
Hide fixed
| private PermissionService permissionService; | ||
| private NodeService nodeService; | ||
| private ActionService actionService; | ||
| static final String NOT_A_VALID_NODEID = "Node Id does not refer to a valid type [folder type]"; |
There was a problem hiding this comment.
Please make the field private
| * The class that wraps the ReST APIs from core. | ||
| */ | ||
|
|
||
| public void setNodes(Nodes nodes) { |
| * Please refer to OpenAPI spec for more details ! | ||
| * <p> | ||
| * If NodeId does not exist, EntityNotFoundException (status 404). | ||
| */ |
There was a problem hiding this comment.
Can we mention the return type as well
|
|
||
| if (properties == null || !properties.containsKey(FolderSizeModel.PROP_OUTPUT)) { | ||
| result.put("status", "NOT INITIATED"); | ||
| } else { |
SathishK-T
reviewed
Jun 25, 2024
| /** | ||
| * Node Size | ||
| * | ||
| * - get folder size |
There was a problem hiding this comment.
Need to add functional description about the class.
| { | ||
| parentId = getSiteContainerNodeId(testSite.getId(), "documentLibrary"); | ||
| return createNode(parentId, name, nodeType, null).getId(); | ||
| } catch (Exception e) |
SathishK-T
reviewed
Jun 25, 2024
| public class NodeFolderSizeRelation implements | ||
| RelationshipResourceAction.CalculateSize<Map<String, Object>>, | ||
| RelationshipResourceAction.ReadById<Map<String, Object>>, | ||
| InitializingBean { |
SathishK-T
reviewed
Jun 25, 2024
| } else { | ||
| Map<String, Object> mapResult = (Map<String, Object>) properties.get(FolderSizeModel.PROP_OUTPUT); | ||
| mapResult.put("status", status); | ||
| result = mapResult; |
There was a problem hiding this comment.
we can return directly mapResult here right.
There was a problem hiding this comment.
No, we cannot return result map directly here, as we are keeping output in the same.
And instead of returning mapResult in every if-else we can return at the end.
SathishK-T
reviewed
Jun 25, 2024
| * | ||
| * @author Mohit Singh | ||
| */ | ||
| public class NodeFolderSizeApiTest extends AbstractBaseApiTest{ |
SathishK-T
reviewed
Jun 25, 2024
| { | ||
| parentId = getSiteContainerNodeId(testSite.getId(), "documentLibrary"); | ||
| return createNode(parentId, name, nodeType, null).getId(); | ||
| } catch (Exception e) |
SathishK-T
reviewed
Jun 25, 2024
| } | ||
|
|
||
| @Override | ||
| public String getScope() { |
SathishK-T
reviewed
Jun 25, 2024
| import org.alfresco.service.namespace.QName; | ||
|
|
||
| @AlfrescoPublicApi | ||
| public class FolderSizeModel { |
SathishK-T
reviewed
Jun 25, 2024
repository/src/main/java/org/alfresco/repo/action/executer/NodeSizeActionExecuter.java
Outdated
Show resolved
Hide resolved
SathishK-T
reviewed
Jun 25, 2024
repository/src/main/java/org/alfresco/repo/action/executer/NodeSizeActionExecuter.java
Outdated
Show resolved
Hide resolved
SathishK-T
reviewed
Jun 25, 2024
| * Action constants | ||
| */ | ||
| public static final String NAME = "folder-size"; | ||
| public static final String PAGE_SIZE = "page-size"; |
There was a problem hiding this comment.
Yes, we are using in Primary Endpoint class.
SathishK-T
reviewed
Jun 25, 2024
| public void executeImpl(Action ruleAction, NodeRef actionedUponNodeRef) | ||
| { | ||
| Serializable serializable = ruleAction.getParameterValue(PAGE_SIZE); | ||
| int maxItems = Integer.parseInt(serializable.toString()); |
There was a problem hiding this comment.
check the exception for the parseInt.
SathishK-T
reviewed
Jun 25, 2024
| searchParameters.setLanguage(SearchService.LANGUAGE_FTS_ALFRESCO); | ||
| searchParameters.setQuery(query); | ||
|
|
||
| try{ |
SathishK-T
reviewed
Jun 25, 2024
| // executing Alfresco FTS query. | ||
| results = searchService.query(searchParameters); | ||
|
|
||
| while(true) { |
|
|
||
| @RelationshipResource(name = "calculateSize", entityResource = NodesEntityResource.class, title = "Calculate size") | ||
| public class NodeFolderSizeRelation implements RelationshipResourceAction.CalculateSize<Map<String, Object>>, | ||
| RelationshipResourceAction.ReadById<Map<String, Object>>, InitializingBean |
suneet-gupta
approved these changes
Jun 25, 2024
added 27 commits
October 20, 2024 11:46
…into feature/MNT-24127-EndpointToCalculateFolderSize # Conflicts: # repository/src/main/resources/alfresco/caches.properties
…eSizeDetailsTests
…into feature/MNT-24127-EndpointToCalculateFolderSize
…eSizeDetailsTests
…eSizeDetailsTests
…eSizeDetailsTests
…ls feature for solr6 subsystem
…into feature/MNT-24127-EndpointToCalculateFolderSize
…ls feature for solr6 subsystem
mohit-singh4
deleted the
feature/MNT-24127-EndpointToCalculateFolderSize
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hyland.atlassian.net/browse/MNT-24127