Fix/apps 2894 node size details automation test #3032
Conversation
…or calculating the NodeSize.
…or calculating the NodeSize.
mohit-singh4
requested review from
suneet-gupta,
pzhyland,
kavitshah-gl and
SathishK-T
…or calculating the NodeSize.
…or calculating the NodeSize.
…or calculating the NodeSize.
…or calculating the NodeSize.
…or calculating the NodeSize.
| jobId = restSizeDetailsModel.getJobId(); | ||
|
|
||
| STEP("4. Wait for 3 seconds for the processing to complete."); | ||
| Utility.waitToLoopTime(3); |
There was a problem hiding this comment.
Please avoid waiting a fixed time. These test might be run on environment with different resources. Sometimes 3 seconds might be enough sometimes it might be not. It will lead to flaky tests and will require additional maintenance in the future. Try to increase the wait time but during that time check the assertions multiple times. You can do it manually in the loop or you can use org.awaitility.Awaitility for instance.
There was a problem hiding this comment.
Acknowledged.
We have replaced the fixed time with Awaitility.await().atMost(Duration.ofSeconds()) and configured it to be used when retrieving the size details.
|
|
||
| @BeforeClass(alwaysRun = true) | ||
| public void dataPreparation() | ||
| { | ||
| user1 = dataUser.createRandomTestUser("User-1"); | ||
| user1 = dataUser.getAdminUser(); |
There was a problem hiding this comment.
Does it mean that only admin users can calculate the folder size?
There was a problem hiding this comment.
No, the Random Test User is also able to calculate the folder size.
We have updated it to use RandomUser instead.
…or calculating the NodeSize.
…or calculating the NodeSize.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
packaging/tests/tas-restapi/src/test/java/org/alfresco/rest/nodes/NodeSizeDetailsTests.java
Fixed
Show fixed
Hide fixed
…or calculating the NodeSize.
mohit-singh4
deleted the
fix/APPS-2894_NodeSizeDetails_AutomationTest
branch
https://hyland.atlassian.net/browse/APPS-2894