Merge pull request #1164 from Alfresco/development

1.8.0
Alfresco · Jul 10, 2019 · 7eafa75 · 7eafa75
2 parents 8557f4e + f1fca4a
commit 7eafa75
Show file tree

Hide file tree

Showing 397 changed files with 20,728 additions and 15,946 deletions.
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -0,0 +1,38 @@
+# This is a comment.
+# Each line is a file pattern followed by one or more owners.
+
+# These owners will be the default owners for everything in
+# the repo. Unless a later match takes precedence,
+# these users will be requested for
+# review when someone opens a pull request.
+*   @DenysVuika @pionnegru
+
+# Order is important; the last matching pattern takes the most
+# precedence. When someone opens a pull request that only
+# modifies JS files, only @js-owner and not the global
+# owner(s) will be requested for a review.
+e2e/*   @adinapitul @pionnegru @DenysVuika
+protractor.conf.js @adinapitul
+
+# You can also use email addresses if you prefer. They'll be
+# used to look up users just like we do for commit author
+# emails.
+#*.go [email protected]
+
+# In this example, @doctocat owns any files in the build/logs
+# directory at the root of the repository and any of its
+# subdirectories.
+#/build/logs/ @doctocat
+
+# The `docs/*` pattern will match files like
+# `docs/getting-started.md` but not further nested files like
+# `docs/build-app/troubleshooting.md`.
+#docs/*  [email protected]
+
+# In this example, @octocat owns any file in an apps directory
+# anywhere in your repository.
+#apps/ @octocat
+
+# In this example, @doctocat owns any file in the `/docs`
+# directory in the root of your repository.
+#/docs/ @doctocat
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
@@ -1,44 +1,12 @@
-## PR Checklist
-Please check if your PR fulfills the following requirements:
+## Definition of Done
 
-```
-- [ ] The commit message follows our guidelines: https://github.com/Alfresco/alfresco-content-app/blob/master/CONTRIBUTING.md#commit
-- [ ] Tests for the changes have been added (for bug fixes / features)
-- [ ] Docs have been added / updated (for bug fixes / features)
-```
+- Technical Documentation
+- Code compliant with Clean Coding rules and tslint
+- Unit tests
+- Automation tests
 
-## PR Type
-What kind of change does this PR introduce?
-
-<!-- Please check the one that applies to this PR using "x". -->
-```
-[ ] Bugfix
-[ ] Feature
-[ ] Code style update (formatting, local variables)
-[ ] Refactoring (no functional changes, no api changes)
-[ ] Build related changes
-[ ] CI related changes
-[ ] Documentation content changes
-[ ] Application / Infrastructure changes
-[ ] Other... Please describe:
-```
-
-## What is the current behavior?
-<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->
+## Current behavior
 
 Issue Number: N/A
 
-
-## What is the new behavior?
-
-
-## Does this PR introduce a breaking change?
-```
-[ ] Yes
-[ ] No
-```
-
-<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->
-
-
-## Other information
+## New behavior
diff --git a/.github/plint.yml b/.github/plint.yml
@@ -1,2 +1,25 @@
 modules:
   - pr.prettier
+  - pr.spellcheck
+
+prettier:
+  options:
+    singleQuote: true
+  exclude:
+    - '*.json'
+
+spellcheck:
+  dictionaries:
+    - softwareTerms
+    - html
+    - en-gb
+    - en_US
+  words:
+    - plint
+    - ngrx
+    - qshare
+    - snackbar
+    - exif
+    - docx
+  exclude:
+    - src/assets/app.extensions.json
diff --git a/.travis.yml b/.travis.yml
@@ -7,27 +7,41 @@ addons:
 language: node_js
 node_js:
   - '10'
-before_script:
-  - sudo /etc/init.d/postgresql stop
+
+cache:
+  directories:
+    - node_modules
+
 before_install:
+  - sudo /etc/init.d/postgresql stop
   - npm install -g npm@latest
   - export DISPLAY=:99.0
   - sh -e /etc/init.d/xvfb start
   - sleep 3
+
+stages:
+  - name: Quality and Unit tests
+  - name: e2e
+
 jobs:
   include:
-    - stage: test
+    - stage: Quality and Unit tests
       name: 'Code quality checks'
-      script:
-        - npm run lint
-    - stage: test
-      name: 'Unit tests'
+      script: npm run lint
+    - name: 'Unit tests'
       script:
         - npm run test:ci
         - bash <(curl -s https://codecov.io/bash) -X gcov
     - stage: e2e
-      name: 'Nginx'
-      script: npm run build.e2e && npm run e2e:docker
-    - stage: e2e
-      name: 'Tomcat'
-      script: npm run build.tomcat.e2e && npm run docker.tomcat.e2e
+      name: Test Suite appNavigation&search
+      script: npm run build.e2e && SUITE="--suite authentication,listViews,navigation,application,pagination,search" npm run e2e:docker
+    - name: Test Suite actionsAvailable
+      script: npm run build.e2e && SUITE="--suite actionsAvailable" npm run e2e:docker
+    - name: Test Suite addRemoveContent
+      script: npm run build.e2e && SUITE="--suite addRemoveContent" npm run e2e:docker
+    - name: Test Suite manageContent
+      script: npm run build.e2e && SUITE="--suite manageContent" npm run e2e:docker
+    - name: Test Suite sharingContent&markFavorite
+      script: npm run build.e2e && SUITE="--suite sharingContent" npm run e2e:docker
+    - name: Test Suite viewContent&metadata&extensions
+      script: npm run build.e2e && SUITE="--suite viewer,infoDrawer,extensions" npm run e2e:docker
diff --git a/.vscode/extensions.json b/.vscode/extensions.json
@@ -1,9 +1,9 @@
 {
   "recommendations": [
-    "eg2.tslint",
+    "ms-vscode.vscode-typescript-tslint-plugin",
     "angular.ng-template",
     "streetsidesoftware.code-spell-checker",
-    "peterjausovec.vscode-docker",
+    "ms-azuretools.vscode-docker",
     "editorconfig.editorconfig",
     "davidanson.vscode-markdownlint",
     "esbenp.prettier-vscode",

diff --git a/README.md b/README.md
@@ -1,4 +1,4 @@
-<p align="left"> <img title="Alfresco" src="alfresco.png" alt="Alfresco - make business flow"></p>
+<p align="left"> <img title="Alfresco" src="alfresco.png" alt="Alfresco - Simply a better way to create amazing digital experiences"></p>
 
 # Alfresco Content Application
 
@@ -32,25 +32,23 @@ Please include a clear description, steps to reproduce and screenshots where app
 
 #### Features added in the latest release
 
-- Edit Offline - lock and download files whilst editing
-- Edit Online - edit files directly in Microsoft Office 
-- [Alfresco Full Text Search (FTS) syntax](https://alfresco-content-app.netlify.com/#/features/search-results?id=alfresco-full-text-search) - enhanced search input to support the Alfresco Search Query Language
-- [Single Sign-On](https://alfresco-content-app.netlify.com/#/getting-started/sso) (SSO) support with Alfresco Identity Service and ADF 3.0.0, basic Kerberos support
+- New language translations (Arabic, Czech, Danish, Finnish, Polish and Swedish)
+- Automatic display of metadata aspects and properties
+- Search result facet improvements
+- Various extensibility improvements and enhancements
 
 Please refer to the [release notes] for details of all changes.
 
 #### High level feature themes planned for 2019
+
 - Extensibility
   - Building on the existing framework to further enhance the developer experience
 - Collaboration & File Management
   - Folder rule creation
   - File/Folder linking via secondary association
 - File Library Management
-  - For managers: manage Library users and requests to join
 - Enhanced UI and user experience
-  - New language translations (Arabic, Czech, Danish, Finnish, Polish and Swedish).
   - Accessibility WCAG AA compliance
-  - Search result facet improvements
   - Search query input assistance
   - Metadata information drawer enhancements
 
@@ -63,6 +61,7 @@ Read up on our guidelines for [contributing] and then check out one of our issue
 
 | ACA Version | Built with | Tested on |
 | ----------- | ---------- | --------- |
+| ACA 1.8     | ADF 3.3.0  | ACS 6.1   |
 | ACA 1.7     | ADF 3.0.0  | ACS 6.1   |
 | ACA 1.6     | ADF 2.6.1  | ACS 6.1   |
 | ACA 1.5     | ADF 2.6.0  | ACS 6.0   |
@@ -95,7 +94,11 @@ Read up on our guidelines for [contributing] and then check out one of our issue
 | 1.7     | Edit Offline               | Lock and unlock for editing, download current version, upload new version.                                                                                                                     |
 | 1.7     | Edit with Microsoft Office | Extension to edit online with Alfresco Office Services (AOS)                                                                                                                                   |
 | 1.7     | Single Sign-On (SSO)       | Support for Alfresco Identity Service, with ADF 3.0.0    |        
-| 1.7     | Search Query Language     | Enhanced search input using the Alfresco Search Query Language    |        
+| 1.7     | Search Query Language      | Enhanced search input using the Alfresco Search Query Language    | 
+| 1.8     | Localizations .            | Arabic, Czech, Danish, Finnish, Polish and Swedish |
+| 1.8     | Metadata improvements      | Automatic display of aspects and properties |
+| 1.8     | Search facet improvements  | Facet intervals and grouped facet queries |
+| 1.8     | Extensibility improvements | Various - see [release notes](https://github.com/Alfresco/alfresco-content-app/releases) for details | 
 
 [contributing]: https://github.com/Alfresco/alfresco-content-app/blob/master/CONTRIBUTING.md
 [github]: https://github.com/Alfresco/alfresco-content-app/issues

diff --git a/alfresco.png b/alfresco.png
diff --git a/angular.json b/angular.json
@@ -22,6 +22,11 @@
               ]
             },
             "assets": [
+              {
+                "glob": "LICENSE",
+                "input": ".",
+                "output": "/"
+              },
               "src/assets",
               "src/favicon-96x96.png",
               "src/app.config.json",
@@ -273,6 +278,41 @@
           }
         }
       }
+    },
+    "aca-shared": {
+      "root": "projects/aca-shared",
+      "sourceRoot": "projects/aca-shared/src",
+      "projectType": "library",
+      "prefix": "lib",
+      "architect": {
+        "build": {
+          "builder": "@angular-devkit/build-ng-packagr:build",
+          "options": {
+            "tsConfig": "projects/aca-shared/tsconfig.lib.json",
+            "project": "projects/aca-shared/ng-package.json"
+          }
+        },
+        "test": {
+          "builder": "@angular-devkit/build-angular:karma",
+          "options": {
+            "main": "projects/aca-shared/test.ts",
+            "tsConfig": "projects/aca-shared/tsconfig.spec.json",
+            "karmaConfig": "projects/aca-shared/karma.conf.js"
+          }
+        },
+        "lint": {
+          "builder": "@angular-devkit/build-angular:tslint",
+          "options": {
+            "tsConfig": [
+              "projects/aca-shared/tsconfig.lib.json",
+              "projects/aca-shared/tsconfig.spec.json"
+            ],
+            "exclude": [
+              "**/node_modules/**"
+            ]
+          }
+        }
+      }
     }
   },
   "defaultProject": "app",

diff --git a/cspell.json b/cspell.json
@@ -42,6 +42,7 @@
     "docx",
     "SOLR",
     "simpletask",
+    "titlecase",
 
     "unshare",
     "qshare",
@@ -62,7 +63,8 @@
     "keycodes",
     "denysvuika",
     "submenu",
-    "submenus"
+    "submenus",
+    "dateitem"
   ],
   "dictionaries": ["html", "en-gb", "en_US"]
 }
diff --git a/docker/entrypoint.sh b/docker/entrypoint.sh
@@ -60,17 +60,23 @@ if [ -n "${APP_CONFIG_OAUTH2_REDIRECT_LOGOUT}" ];then
 fi
 
 if [[ $ACSURL ]]; then
-  sed -i s%{protocol}//{hostname}{:port}%"$ACSURL"%g /tmp/app.config.json && \
+  replace="\/"
+  encoded=${ACSURL//\//$replace}
+  sed -i s%{protocol}//{hostname}{:port}%"$encoded"%g /tmp/app.config.json && \
   cat /tmp/app.config.json > ./app.config.json
 fi
 
 if [[ $BASEPATH ]]; then
-  sed -i s%href=\"/\"%href=\""$BASEPATH"\"%g /tmp/index.html && \
+  replace="\/"
+  encoded=${BASEPATH//\//$replace}
+  sed -i s%href=\"/\"%href=\""$encoded"\"%g /tmp/index.html && \
   cat /tmp/index.html > ./index.html
 fi
 
 if [ -n "${APP_BASE_SHARE_URL}" ];then
-  sed -e "s/\"baseShareUrl\": \".*\"/\"baseShareUrl\": \"${APP_BASE_SHARE_URL}\"/g" \
+  replace="\/"
+  encoded=${APP_BASE_SHARE_URL//\//$replace}
+  sed -e "s/\"baseShareUrl\": \".*\"/\"baseShareUrl\": \"${encoded}\"/g" \
     -i /tmp/app.config.json && \
   cat /tmp/app.config.json > ./app.config.json
 fi

diff --git a/docs/README.md b/docs/README.md
@@ -24,6 +24,7 @@ The documentation is divided into the following sections:
 
 | ACA Version | Built with | Tested on |
 | ----------- | ---------- | --------- |
+| ACA 1.8     | ADF 3.3.0  | ACS 6.1   |
 | ACA 1.7     | ADF 3.0.0  | ACS 6.1   |
 | ACA 1.6     | ADF 2.6.1  | ACS 6.1   |
 | ACA 1.5     | ADF 2.6.0  | ACS 6.0   |