Skip to content

Commit

Permalink
Revert "mix local and remote build contexts"
Browse files Browse the repository at this point in the history
This reverts commit 6622f9c.
  • Loading branch information
alxgomz committed Nov 21, 2024
1 parent 9691d2d commit 58d8581
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
6 changes: 2 additions & 4 deletions audit-storage/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@ ARG ALFRESCO_AUDIT_STORAGE_GROUP_ID
ARG ALFRESCO_AUDIT_STORAGE_USER_NAME
ARG ALFRESCO_AUDIT_STORAGE_USER_ID

COPY alfresco-audit-storage-app*.jar /opt/app.jar
COPY --from=local alfresco-audit-storage-app*.jar /opt/app.jar
ADD alfresco-audit-storage-app*.jar /opt/app.jar

Check warning on line 10 in audit-storage/Dockerfile

View workflow job for this annotation

GitHub Actions / kics

[MEDIUM] Add Instead of Copy

Using ADD to load external installation scripts could lead to an evil web server leveraging this and loading a malicious script.

Check warning

Code scanning / KICS

Add Instead of Copy Warning

'ADD' alfresco-audit-storage-app*.jar

ENV AUDIT_ENTRYSTORAGE_OPENSEARCH_CONNECTOR_USERNAME=admin

Expand All @@ -18,6 +17,5 @@ RUN groupadd -g ${ALFRESCO_AUDIT_STORAGE_GROUP_ID} ${ALFRESCO_AUDIT_STORAGE_GROU

USER ${ALFRESCO_AUDIT_STORAGE_USER_NAME}

ADD entrypoint.sh /entrypoint.sh

COPY entrypoint.sh /entrypoint.sh
CMD ["/entrypoint.sh"]
1 change: 0 additions & 1 deletion docker-bake.hcl
Original file line number Diff line number Diff line change
Expand Up @@ -801,7 +801,6 @@ target "audit-storage" {
dockerfile = "Dockerfile"
inherits = ["java_base"]
contexts = {
local = "cwd://audit-storage"
java_base = "target:java_base"
}
args = {
Expand Down

0 comments on commit 58d8581

Please sign in to comment.