Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPSEXP-2849 Create reusable build/test workflow with ACS 7.4 support #110

Merged
merged 36 commits into from
Nov 7, 2024
Merged

OPSEXP-2849 Create reusable build/test workflow with ACS 7.4 support #110

merged 36 commits into from
Nov 7, 2024

Conversation

pmacius
Copy link
Contributor

@pmacius pmacius commented Nov 4, 2024 •
edited
Loading

Description

  • Created reusable workflow for building and testing
  • Added ACS 7.4
  • ARM builds only for the current ACS version 23
  • fetch-compose.sh script is by default downloading also 7.4-compose file
  • Tomcat for versions prior to 23 is build with version 9 (vars set in workflow step)
  • Added steps which calculates the files names for helm and compose

Related Issue

OPSEXP-2849

Checklist

  • My code follows the project's coding standards.
  • I have updated the documentation accordingly.

Documentation will be updated as a part of another task

@pmacius pmacius force-pushed the OPSEXP-2849-multi-version branch 2 times, most recently from 1c2a0f2 to 9b6c722 Compare November 5, 2024 13:33
@pmacius pmacius changed the title OPSEXP-2849 Allow building and testing multiple versions of ACS OPSEXP-2849 Create reusable build/test workflow with ACS 7.4 support Nov 5, 2024
@pmacius pmacius requested review from gionn and alxgomz November 5, 2024 16:40
@pmacius pmacius requested a review from gionn November 7, 2024 10:15
gionn
gionn reviewed Nov 7, 2024
View reviewed changes
Copy link
Member

@gionn gionn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything else LGTM

.github/workflows/reusable_build_and_test.yml Show resolved Hide resolved
@pmacius pmacius requested a review from gionn November 7, 2024 11:43
@pmacius pmacius requested review from gionn November 7, 2024 14:13
alxgomz
alxgomz requested changes Nov 7, 2024
View reviewed changes
scripts/fetch-artifacts.sh Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
@pmacius pmacius requested a review from alxgomz November 7, 2024 16:37
@pmacius pmacius merged commit 3bdebb9 into main Nov 7, 2024
20 checks passed
@pmacius pmacius deleted the OPSEXP-2849-multi-version branch November 7, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxgomz alxgomz alxgomz approved these changes

@gionn gionn gionn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmacius @gionn @alxgomz