Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APPS-3035] fix for spring version update #174

Merged
merged 11 commits into from
Oct 4, 2024

Conversation

purusothaman-mm
Copy link
Contributor

@CLAassistant
Copy link

CLAassistant commented Sep 25, 2024

CLA assistant check
All committers have signed the CLA.

@suneet-gupta
Copy link
Contributor

license/cla check is failing. Kindly sign the Contributor License Aggrement.

@@ -2,6 +2,7 @@
spring:
main:
banner_mode: "off"
allow-circular-references: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need allow-circular-reference to be true

Copy link
Contributor Author

@purusothaman-mm purusothaman-mm Oct 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the circular reference configuration used in yaml

Copy link
Contributor

@suneet-gupta suneet-gupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@SathishK-T SathishK-T left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@purusothaman-mm purusothaman-mm merged commit 6b0cf33 into master Oct 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants