Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directories and Symbolic Resource Sharers #156

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

olynch
Copy link
Member

@olynch olynch commented Jul 3, 2024

This supercedes #136; I couldn't figure out how to rebase cleanly so I ended up just diffing against main and then applying that diff in a single commit.

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 92.55499% with 44 lines in your changes missing coverage. Please review.

Project coverage is 93.51%. Comparing base (bd3df8e) to head (7e81a46).

Files Patch % Lines
src/syntax/gats/ast.jl 82.08% 12 Missing ⚠️
src/util/Dtrys.jl 95.15% 11 Missing ⚠️
src/nonstdlib/dynamics/ResourceSharers.jl 94.79% 9 Missing ⚠️
src/syntax/gats/algorithms.jl 61.11% 7 Missing ⚠️
src/syntax/gats/closures.jl 95.23% 3 Missing ⚠️
src/syntax/gats/exprinterop.jl 88.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
- Coverage   93.85%   93.51%   -0.34%     
==========================================
  Files          38       41       +3     
  Lines        2229     2777     +548     
==========================================
+ Hits         2092     2597     +505     
- Misses        137      180      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olynch olynch force-pushed the symbolic-resource-sharers branch from 40148fa to 7e81a46 Compare July 3, 2024 01:46
@olynch olynch requested a review from quffaro July 3, 2024 01:53
@epatters epatters added the enhancement New feature or request label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants