FD detector #13476

pkurash · 2024-09-04T07:24:10Z

Software model for future FV0 like detector consisting of two segmented scintillator disks.

…etector3 Fix geometry error and json

github-actions · 2024-09-04T07:24:21Z

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass3
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0

mconcas · 2024-09-04T07:36:22Z

Software model for future FV0 like detector consisting of two segmented scintillator disks.

Looks reasonably good to me, I will find the time to test it locally. Thanks!

DataFormats/Detectors/Common/include/DetectorsCommonDataFormats/DetID.h

…etector4

mconcas

Approving to spin the CI

alibuild · 2025-01-29T09:39:06Z

Error while checking build/O2/fullCI_slc9 for c7bf68d at 2025-01-29 10:39:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/13476-slc9_x86-64/0/Detectors/Upgrades/ALICE3/FD/base/src/GeometryTGeo.cxx:37:15: error: use '= default' to define a trivial destructor [modernize-use-equals-default]
/sw/SOURCES/O2/13476-slc9_x86-64/0/Detectors/Upgrades/ALICE3/FD/simulation/src/Detector.cxx:368:15: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/13476-slc9_x86-64/0/Detectors/Upgrades/ALICE3/FD/simulation/src/Detector.cxx:381:19: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/13476-slc9_x86-64/0/Detectors/Upgrades/ALICE3/FD/simulation/src/Detector.cxx:383:9: error: statement should be inside braces [readability-braces-around-statements]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

alibuild · 2025-01-29T11:06:00Z

Error while checking build/O2/fullCI for c7bf68d at 2025-01-29 12:05:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/13476-slc8_x86-64/0/Detectors/Upgrades/ALICE3/FD/base/src/GeometryTGeo.cxx:37:15: error: use '= default' to define a trivial destructor [modernize-use-equals-default]
/sw/SOURCES/O2/13476-slc8_x86-64/0/Detectors/Upgrades/ALICE3/FD/simulation/src/Detector.cxx:368:15: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/13476-slc8_x86-64/0/Detectors/Upgrades/ALICE3/FD/simulation/src/Detector.cxx:381:19: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/13476-slc8_x86-64/0/Detectors/Upgrades/ALICE3/FD/simulation/src/Detector.cxx:383:9: error: statement should be inside braces [readability-braces-around-statements]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

mconcas

approving fo CI

alibuild · 2025-02-02T13:39:34Z

Error while checking build/O2/fullCI_slc9 for 96ad811 at 2025-02-02 16:19:

++ cp /sw/slc9_x86-64/O2/13476-slc9_x86-64-local2/compile_commands.json .
+++ python3 -c 'import json, os; print(os.path.commonprefix([x["file"] for x in json.loads(open("compile_commands.json").read()) if "sw/BUILD" not in x["file"] and "G__" not in x["file"] and x["file"].endswith(".cxx")]))'
++ O2_SRC=/sw/SOURCES/O2/13476-slc9_x86-64/0/
++ [[ -e /sw/SOURCES/O2/13476-slc9_x86-64/0//CMakeLists.txt ]]

Full log here.

alibuild · 2025-02-02T15:35:13Z

Error while checking build/O2/fullCI for 96ad811 at 2025-02-02 16:35:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'

Full log here.

…ge in eta independent of their position

mconcas

ci

alibuild · 2025-02-05T09:27:46Z

Error while checking build/O2/fullCI for c19814f at 2025-02-05 10:27:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/O2-full-system-test-latest/log
Detected critical problem in logfile reco_NOGPU.log
reco_NOGPU.log:[28030:internal-dpl-ccdb-backend]: [09:27:32][ERROR] Exception while running: Fatal error. Rethrowing.
reco_NOGPU.log-[28030:internal-dpl-ccdb-backend]: [09:27:32][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-itsmft-stf-decoder-workflow, device shutting down. Reason: Fatal error
[28030:internal-dpl-ccdb-backend]: [09:27:32][ERROR] CCDBDownloader CURL transfer error - Unsupported protocol
[28030:internal-dpl-ccdb-backend]: [09:27:32][ERROR] CcdbDownloader finished transfer http://alice-ccdb.cern.ch/GLO/Param/MatLUT/1546300800000/3f0d0f81-99d9-11ee-b9a2-200114580202 for 1550600800000 (agent_id: alimetal09.cern.ch-1738747647-76RLRZ) with http code: 0
[28030:internal-dpl-ccdb-backend]: [09:27:32][FATAL] Unable to find object GLO/Param/MatLUT/1550600800000
[28030:internal-dpl-ccdb-backend]: [09:27:32][ERROR] Exception while running: Fatal error. Rethrowing.
[28030:internal-dpl-ccdb-backend]: [09:27:32][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-itsmft-stf-decoder-workflow, device shutting down. Reason: Fatal error
[ERROR] Workflow crashed - PID 28030 (internal-dpl-ccdb-backend) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR]  - Device internal-dpl-ccdb-backend: pid 28030 (exit 128)
[INFO]    - First error: [09:27:32][FATAL] Unable to find object GLO/Param/MatLUT/1550600800000
[ERROR] SEVERE: Device internal-dpl-ccdb-backend (28030) had at least one message above severity 5: Unable to find object GLO/Param/MatLUT/1550600800000


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/5c490f77479e703dea39788684109b5c1416bcf8/slc8_x86-64/o2checkcode/1.0-local68/etc/modulefiles
++ cat
--

Full log here.

alibuild · 2025-02-05T09:47:23Z

Error while checking build/O2/fullCI_slc9 for c19814f at 2025-02-05 10:47:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/O2-sim-challenge-test-latest/log
./sim-challenge.logDetected critical problem in logfile tpcreco.log
./sim-challenge.logtpcreco.log:[8330:internal-dpl-ccdb-backend]: [10:47:12][ERROR] Exception while running: Fatal error. Rethrowing.
./sim-challenge.logtpcreco.log-[8330:internal-dpl-ccdb-backend]: [10:47:12][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-tpc-reco-workflow, device shutting down. Reason: Fatal error
./sim-challenge.log[8330:internal-dpl-ccdb-backend]: [10:47:12][ERROR] CCDBDownloader CURL transfer error - Unsupported protocol
./sim-challenge.log[8330:internal-dpl-ccdb-backend]: [10:47:12][ERROR] CcdbDownloader finished transfer http://alice-ccdb.cern.ch/GLO/Param/MatLUT/1546300800000/3f0d0f81-99d9-11ee-b9a2-200114580202 for 1546300800000 (agent_id: alimetal04.cern.ch-1738748829-0eGPHh) with http code: 0
./sim-challenge.log[8330:internal-dpl-ccdb-backend]: [10:47:12][FATAL] Unable to find object GLO/Param/MatLUT/1546300800000
./sim-challenge.log[8330:internal-dpl-ccdb-backend]: [10:47:12][ERROR] Exception while running: Fatal error. Rethrowing.
./sim-challenge.log[8330:internal-dpl-ccdb-backend]: [10:47:12][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-tpc-reco-workflow, device shutting down. Reason: Fatal error
./sim-challenge.log[ERROR] Workflow crashed - PID 8330 (internal-dpl-ccdb-backend) did not exit correctly however it's not clear why. Exit code forced to 128.
./sim-challenge.log[ERROR]  - Device internal-dpl-ccdb-backend: pid 8330 (exit 128)
./sim-challenge.log[INFO]    - First error: [10:47:12][FATAL] Unable to find object GLO/Param/MatLUT/1546300800000
./sim-challenge.log[ERROR] SEVERE: Device internal-dpl-ccdb-backend (8330) had at least one message above severity 5: Unable to find object GLO/Param/MatLUT/1546300800000
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/49}
./digi.log[5764:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[5764:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[5764:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./digi.log[5764:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./digi.log[5764:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./digi.log[5764:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./digi.log[5764:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./digi.log[5764:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./digi.log[5764:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
./digi.log[5764:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/49}
./digi.log[5772:TPCDigitizer_3]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
[0 more errors; see full log]

Full log here.

pkurash added 7 commits September 2, 2024 21:25

basic geometry and data format for new detector

1481922

Merge branch 'AliceO2Group:dev' into new-detector3

07dc65a

fixed geometry and json

c417fcb

Merge branch 'new-detector3' of github.com:pkurash/AliceO2 into new-d…

58436cd

…etector3 Fix geometry error and json

fixed hits

44bef8c

updated geometry and detector source code

deadde8

Merge branch 'AliceO2Group:dev' into new-detector4

e77714d

pkurash requested review from mconcas, shahor02, a team, sawenzel and benedikt-voelkel as code owners September 4, 2024 07:24

alibuild mentioned this pull request Sep 4, 2024

Please consider the following formatting changes to #13476 pkurash/AliceO2#1

Closed

shahor02 requested changes Sep 4, 2024

View reviewed changes

DataFormats/Detectors/Common/include/DetectorsCommonDataFormats/DetID.h Outdated Show resolved Hide resolved

pkurash added 13 commits September 4, 2024 16:36

updated geometry and detector source code

dd8656e

Merge branch 'new-detector4' of github.com:pkurash/AliceO2 into new-d…

ad83fef

…etector4

minor fixes

73d3a4a

Merge branch 'AliceO2Group:dev' into new-detector4

9c4883c

Merge branch 'AliceO2Group:dev' into new-detector4

605bf80

Merge branch 'AliceO2Group:dev' into new-detector4

f500ae8

sensitive volumes

863ff24

geometry update

69019f6

geometry update

84943c2

Merge branch 'AliceO2Group:dev' into new-detector4

d04a89c

enable hits

7c92e44

enable hits

2b00551

enable hits

c070c3f

alibuild mentioned this pull request Dec 21, 2024

Please consider the following formatting changes to #13476 pkurash/AliceO2#3

Closed

pkurash added 6 commits December 21, 2024 18:19

created new namespace

be15827

created new namespace

2b8a26e

Merge branch 'AliceO2Group:dev' into new-detector4

d79cf33

Merge branch 'AliceO2Group:dev' into new-detector4

fe0e9e3

Merge branch 'AliceO2Group:dev' into new-detector4

a38641e

change name of the detector

fbf4595

alibuild mentioned this pull request Jan 27, 2025

Please consider the following formatting changes to #13476 pkurash/AliceO2#4

Closed

change name of the detector

c7bf68d

mconcas previously approved these changes Jan 29, 2025

View reviewed changes

Merge branch 'AliceO2Group:dev' into new-detector4

e4cee5d

pkurash changed the title ~~FVD detector~~ FD detector Jan 29, 2025

check errors

e02c8b4

pkurash dismissed mconcas’s stale review via e02c8b4 January 29, 2025 11:53

alibuild mentioned this pull request Jan 29, 2025

Please consider the following formatting changes to #13476 pkurash/AliceO2#5

Closed

check errors

a37a782

mconcas previously approved these changes Jan 30, 2025

View reviewed changes

pkurash added 2 commits January 31, 2025 12:13

Merge branch 'AliceO2Group:dev' into new-detector4

75e5611

Merge branch 'AliceO2Group:dev' into new-detector4

96ad811

Flexible ring radii, a new Boolean switch for module A, module covera…

dcef291

…ge in eta independent of their position

pkurash dismissed mconcas’s stale review via dcef291 February 2, 2025 17:12

pkurash added 2 commits February 3, 2025 08:14

correct default number of ring of A side

f27e878

Merge branch 'AliceO2Group:dev' into new-detector4

c19814f

mconcas approved these changes Feb 5, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FD detector #13476

FD detector #13476

pkurash commented Sep 4, 2024

github-actions bot commented Sep 4, 2024

mconcas commented Sep 4, 2024

mconcas left a comment

alibuild commented Jan 29, 2025

alibuild commented Jan 29, 2025

mconcas left a comment

alibuild commented Feb 2, 2025 •

edited

Loading

alibuild commented Feb 2, 2025

mconcas left a comment

alibuild commented Feb 5, 2025

alibuild commented Feb 5, 2025

FD detector #13476

Are you sure you want to change the base?

FD detector #13476

Conversation

pkurash commented Sep 4, 2024

github-actions bot commented Sep 4, 2024

mconcas commented Sep 4, 2024

mconcas left a comment

Choose a reason for hiding this comment

alibuild commented Jan 29, 2025

alibuild commented Jan 29, 2025

mconcas left a comment

Choose a reason for hiding this comment

alibuild commented Feb 2, 2025 • edited Loading

alibuild commented Feb 2, 2025

mconcas left a comment

Choose a reason for hiding this comment

alibuild commented Feb 5, 2025

alibuild commented Feb 5, 2025

alibuild commented Feb 2, 2025 •

edited

Loading