-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve TOF infos in TPCtimeseries #13853
base: dev
Are you sure you want to change the base?
Conversation
REQUEST FOR PRODUCTION RELEASES:
This will add The following labels are available |
a959478
to
5d1e061
Compare
Hello @noferini, Thank you for your modification. I need to test the new time series before proceeding with the merge. Marian |
This relates to the JIRA O2-4592 (https://its.cern.ch/jira/browse/O2-4592) and pull request: |
Code to test the time series - Example running of the time series and skimmed dataHello @noferini
|
Hi @miranov25, |
Hello @noferini, I see that you’ve already removed FT0/A+C for the TOF information (mTOFSignal). If I understand your modification correctly, the line: It would indeed be useful to verify whether Separately, we’ve been discussing within the AO2D framework the TOF momentum and effective TOF momentum. For example, if I wanted to create a time series for the Regarding the bitmask, you constructed it manually in the code. Is its definition consistent with the AO2D definition, or is it currently not included in AO2D at all? As for the time-dependent
Best regards, |
Yes, for the moment only the fine part. As I mentioned, the BC is not yet subtracted.
In principle with FT0-AC we have also an independent measurement of Z-vertex. This information is already available and we can use it. For vertex-time I can have a look to what is available in the task (vertex-time is in any case less precise that Z-vertex I guess)
Here, I don't know how TOF momentum and effective TOF momentum are defined. Can you add more details?
In AO2D only chi2 is propagated, the information related to chi2 can be easily recover in AO2D analysis. The information related to TOF cluster topology (single/multiple hits) are not yet ported. In principle these infos are needed only for TOF performance studies and it is enough for us to have them in time-series.
One more info we can consider to propagate is the time-dependent TOF acceptance. This requires a bit of work (especially for MC). If it is useful for you I can have a look (but it will require more time so it is probably worth not to include it in the first iteration) |
60058a8
to
7f3ed52
Compare
I am focused on using the TOF as an additional tool for distortion monitoring and eventual correction. At low β, the time bias is strongly influenced by the p_T bias (the importance of other effects should also be quantified). We can extract a correction by fitting the time bias as a function of the local p_T bias (for low β particles such as protons, kaons, and deuterons). While it is unclear if other effects are contributing, we can assume that the relative change of the time bias over time or space is independent of the material budget. In the K⁰, Λ, and D⁰ analyses, we observed that the Run 1 and Run 2 resolutions are significantly better than in Run 3, even at relatively low momenta. This fact cannot be explained by a constant q/p_T shift. However, what we observe is that the q/p_T bias is indeed dependent on the rate, position, and q/p_T. As a demonstration example, we can use the DCA as a function of q/p_T and rate, the EMCAL E/p measurement, and the easily accessible TOF delta time measurement. In the figure below, you can find the delta time profile for kaons and pions as a function of φ, which resembles the previously observed E/p measurement and electron/positron behavior in the EMCAL. At the moment, we do not yet have enough statistics to extract reliable dt/dp_rel fits. However, we plan to extract them for some example fills with significant rate variations. It would be preferable to enable the necessary TOF information in production as soon as possible. For that we will need delta Time These fits will be validated by applying the corrections to V⁰ and D⁰ analyses. Example query in the AO2D analysis:
|
Hi @miranov25 , In general I don't like to use Nsigma, I think that for our purpose it is better to use (t - texp) and get the shift in ps. |
From what I understand, I believe we can retrieve the required information. In the example above, I used NSigma as it was readily available in the AO2D. The advantage of the time series approach is that the analysis is much more efficient, as the time series size is approximately For the next iteration (after this pull request), I propose creating a TOF delta time series to further accelerate the analysis. @wiechula, @shahor02, could you please review and approve @noferini's pull request? Best regards, |
Hi @miranov25 , all, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noferini see one suggestion below. Note that the FT0 data are loaded conditionally (if useft0
is true) but is used unconditionally in the run. It will not crash, simply
const auto& ft0rec = recoData.getFT0RecPoints(); |
t0array
will never be filled.
@shahor02 if (useft0) { Am I wrong? |
@noferini if you want it conditionally, yes, I was just stating that it |
@shahor02 if (useft0) { Am I wrong?
Hi @shahor02 , I checked again the code. What you said it is true, I added the option in order not to break simulation (O2DPG). in principle I can make FT0 mandatory but I have to wait that also O2DPG PR is merged. As soon as O2DPG PR is merged I can remove the condition. |
Error while checking build/O2/fullCI for f80f564 at 2025-01-17 18:53:
Full log here. |
This is to port additional TOF(FT0 event time) infos in TPC timeseries
@miranov25 @ercolessi