Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fake/correct status for barrel tracks #13909

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

shahor02
Copy link
Collaborator

The fMcMask bit 15 (fake global track label or TOF_label != TPC_lable) was wrong since original TOF cluster label (set in the reconstruction) was compared with TPC remapped label prepared for AOD storage.
In fact, we don't need to consider separately the global_label.isFake and TOF-TPC mismach: TOF is the last detector in the matching process and the global track label is determined by the TPC track label. Hence, if the TOF match is present but its cluster is not contributed by the TPC track, the global label isFake will be necessarilly true, and vice versa.

Also, the status of bit 13 (flagging ITS-TPC mismatch) was covering only track-to-track matches but not those from the afterburner.

Now settings of fakeness relies on the isFake status from the reconstruction.

The fMcMask bit 15 (fake global track label or TOF_label != TPC_lable) was
wrong since original TOF cluster label (set in the reconstruction) was compared
with TPC remapped label prepared for AOD storage.
In fact, we don't need to consider separately the global_label.isFake and TOF-TPC mismach:
TOF is the last detector in the matching process and the global track label is determined
by the TPC track label. Hence, if the TOF match is present but its cluster is not contributed
by the TPC track, the global label isFake will be necessarilly true, and vice versa.

Also, the status of bit 13 (flagging ITS-TPC mismatch) was covering only track-to-track
matches but not those from the afterburner.

Now settings of fakeness relies on the isFake status from the reconstruction.
@shahor02 shahor02 requested a review from a team as a code owner January 28, 2025 13:43
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@shahor02
Copy link
Collaborator Author

@njacazio this is all what is needed to fix the wrong TOF fakeness problem: the fake/correct status is already set in global track labels, better to rely on them.
If you want to add more info (e.g. ITS particular layer fake/correct status), as #13902 hints, please rebase your PR to this one and continue from that point.

@shahor02
Copy link
Collaborator Author

pinging also @ddobrigk

@njacazio
Copy link
Contributor

Hi @shahor02 many thanks for the changes, I think we can merge it then! In the meantime I will test it locally.
Tagging also @noferini

@shahor02 shahor02 merged commit dff469f into AliceO2Group:dev Jan 29, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants