-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MCH: introduce digit modifier in filtering workflow #13924
base: dev
Are you sure you want to change the base?
MCH: introduce digit modifier in filtering workflow #13924
Conversation
REQUEST FOR PRODUCTION RELEASES:
This will add The following labels are available |
1637c27
to
905fbcf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aferrero2707 . Appart from details of implementation, I am also wondering here about the connexion between the digit padId and the BadChannels (and the statusMap in general) and how this is affected by this bug in the mapping and the fix.
905fbcf
to
36ffc5f
Compare
36ffc5f
to
c2bcad4
Compare
The digit modifier allows to change the contents of the digits in the filtering step. It is introduced in order to correct some mapping issues in the CTFs already collected, but the interface is general, and in the future it might be used for any kind of digit manipulation, if needed.
c2bcad4
to
e51f1d3
Compare
Error while checking build/O2/fullCI_slc9 for e51f1d3 at 2025-02-05 13:05:
Full log here. |
// this should never occur in this specific case, as all channels of this group of boards | ||
// is connected to pads, hence we rise an exception | ||
throw std::out_of_range(std::format("Unknown padId for DE{} DS{} channel {}", deId, dsId, channel)); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @aferrero2707 , the test on MacOS fails because of std::format. I think C++20 is not yet fully supported and we should still use fmt::format.
The digit modifier allows to change the contents of the digits in the filtering step.
It is introduced in order to correct some mapping issues in the CTFs already collected, but the interface is general, and in the future it might be used for any kind of digit manipulation, if needed.