Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWGHF: Follow issue #2156 #2460

Closed
wants to merge 1 commit into from
Closed

Conversation

AlexBigO
Copy link
Contributor

Following Vit's issue.

@github-actions
Copy link

This PR has not been updated in the last 30 days. Is it still needed? Unless further action is taken, it will be closed in 5 days.

@github-actions github-actions bot added the stale label May 22, 2023
@vkucera
Copy link
Collaborator

vkucera commented May 24, 2023

Thank you @AlexBigO . I have been hesitant with merging this since it will require changing dependencies of all selector wagons on Hyperloop but I guess we should just move ahead with it. Also the configuration of both versions of the PID workflows (full vs restricted) seem almost identical. My last concern is whether this has been tested at least with the Lc -> p K pi selector to confirm that it does not change the selection.

@fcolamar can you think of anything else to check before merging this?

@AlexBigO
Copy link
Contributor Author

AlexBigO commented May 24, 2023

Hi @vkucera ! By grepping tofExp or tpcExp in PWGHF/, I didn't get any output so I supposed there should be no difference between full and restricted PID workflows (as we currently only call NSigma getters in PWGHF/).
However, after testing it on Dplus and B0 selectors, I get a small difference between the 2 workflows. For instance, I go from 6779 selected D+ with full PID to 6852 selected D+ with restricted PID.
Could it come from the difference of column definition between restricted and full PID?

@github-actions github-actions bot closed this May 30, 2023
@vkucera
Copy link
Collaborator

vkucera commented May 30, 2023

@AlexBigO , for this we should check the difference in granularity and binning edges to see if that could be the effect of different binning. One could also compare the nsigma distributions of selected candidates for the two types of tables to check where the difference comes from.

@vkucera
Copy link
Collaborator

vkucera commented Jun 7, 2023

@AlexBigO , did you manage to identify the source of the differences?

@AlexBigO
Copy link
Contributor Author

AlexBigO commented Jun 8, 2023

Hi @vkucera . Sorry, my mid-term defense is approaching so I put this study on pause to work fully on the analysis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants