Cleanup #3
Open
Cleanup #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 2, 2017 11:09
1. Cleanup: Many of the #ifdef's around constructors are removed as no longer neccessary. 2. Cleanup: mono_tum now takes an optional save filename (instead of 0 / 1) 3. Cleanup: System no longer implicitly saves the map. Instead, the user should call System::SaveMap(filename). This allows saving a map to a different filename than it was loaded from. 4. The filename to load a map from is passed into the System() constructor rather than fetching it was settings. (part of allowing load and save filenames to differ). 5. Bugfix: SaveMap and LoadMap now use 'filename' exclusively, instead of a mix of 'filename' and 'mapfile'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of small cleanups mostly aimed as reducing the amount of #ifdef'ing :)