[resolver] Select a non-main branch option #5075
Open
+38
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryx2
changed the title
|
@neubig passes tests :) |
neubig
reviewed
Nov 20, 2024
There was a problem hiding this comment.
Hey thanks! I'm a bit confused by separating source_branch and target_branch though. Is there any situation under which you'd want to get the code from one branch and then send the PR back to a different branch? I'd be inclined to just have a single branch specified here for simplicity.
|
sure; changed it to just 'target_branch' |
|
@neubig hey, could i get this lgtm'd |
|
Ahh, sorry, when you're ready to have it re-reviewed it helps if you click the "cycle" icon on the top right of the screen, which will put it back on my reviewing queue. Just did that now and I'll take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
End-user friendly description of the problem this fixes or functionality that this introduces
Give a summary of what the PR does, explaining any non-trivial design decisions
I usually do my development on a feature branch, but the current resolver only has the ability to develop on main
Link of any specific issues this addresses