Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add skip button to hero page #5189

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

malhotra5
Copy link
Contributor

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below

Give a summary of what the PR does, explaining any non-trivial design decisions

The linked issue was going stale and seemed quite helpful to have. Added a "skip" button to bypass the hero page. Followed general design theme for the button but feedback here would be appreciated!


Link of any specific issues this addresses
#4503

@enyst enyst requested a review from amanape November 21, 2024 21:19
Copy link
Member

@amanape amanape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not entirely sure if the original issue has been resolved. When a user uploads a project directory, they’re already redirected immediately to /app. @tobitege, could you confirm if this was the intended behavior?

In any case, we’ll need confirmation from Paul, the designer. "Skip" feels out of place here (there isn't quite anything to skip). Something like "Jump right in" might be more fitting.

<button
className="absolute bottom-4 right-4 text-white px-4 py-2 rounded cursor-pointer border-1 border-neutral-600"
onClick={() => {
window.location.href = "/app";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
window.location.href = "/app";
navigate("/app");

Further reading: https://remix.run/docs/hi/main/hooks/use-navigate

@tobitege
Copy link
Collaborator

@amanape Personally, I don't plan to use this upload feature, but still use mapped local folder as my codebase doesn't use GitHub.
Whichever option would allow to skip the hero page would be fine with me. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants