Fix issue #5154: [Bug]: FinishTool doesn't have a tool response so the agent loses its content #5231
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #5154.
The issue has been successfully resolved. The PR fixes the core problem where FinishAction with source='agent' was being treated incorrectly in the conversation flow. Here's a summary for the reviewer:
This PR fixes a regression in function calling where FinishAction with source='agent' wasn't being properly handled. The changes:
The solution maintains proper conversation flow while ensuring:
These changes align with LLM API requirements while fixing the regression in function calling behavior.
Automatic fix generated by OpenHands 🙌