Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworked Occultism Quests #2309

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

KingofSpiders13
Copy link

@KingofSpiders13 KingofSpiders13 commented Feb 27, 2025

I re-did the pull request after the base code was apparently flawed.
Thanks to TheBedrockMaster for helping me with this.

List of changes:

  • Rearranged 90% of the existing quests to make the flow more natural/readable
  • Renamed a few quests (mainly to add Tools of the Trade: to the beginning of tool quests)
  • Deleted some quests and merged their requirements/text/rewards into new quests
  • Changed dependencies of certain quests to better fit in with added quests
  • Added more requirements to certain quests to better assist players in understanding the mod
  • Changed descriptions of several of the existing quests to better assist players in understanding the mod
  • Added quests:
    • The Basics of Rituals
    • Tools of the Trade: Butcher's Knife
    • Eziveus' Spectral Compulsion
    • Lime Chalk
    • Green Chalk
    • Strigeor's Higher Binding
    • Ihagan's Enthrallment
    • Chalk Repair
    • Tools of the Trade: Ritual Satchel
    • Gray Chalk
    • Orange Chalk
    • Abras' Open Conjure
    • Abras' Open Commanding Conjure
    • Pink Chalk
    • Red Chalk
    • Sevira's Permanent Confinement
    • Tools of the Trade: Artisanal Ritual Satchel
    • Iesnium Sacrificial Bowl
    • Repairing Items
    • Black Chalk
    • Abras' Fortified Conjure
    • Blue Chalk
    • Uphyxes' Inverted Tower
    • Xeovrenth Adjure
    • Fatmas' Incentivized Attraction
    • Iesnium Anvil
    • Magenta Chalk
    • Brown Chalk
    • Cyan Chalk
    • Light Blue Chalk
    • Osorin's Unbound Calling
    • Ronaza's Contact
    • Trinity Gem
    • Rainbow Chalk
    • Eldritch Chalice
    • Void Chalk (optional)
    • What's next?

I'm going to see if this works but I might not be able to import these correctly (I would therefore be leaving them out)
I was able to fully integrate TheBedrockMaster's changes to the new code.
@TheBedrockMaster TheBedrockMaster changed the title Occultism Questline Reqwork - Re-PR Reworked Occultism Quests Feb 27, 2025
@KingofSpiders13
Copy link
Author

this is in no way a "please accept my changes" but how long generally does it take for pull request to get added or denied? ive never been a part of this process before and id like to know

@TheBedrockMaster
Copy link
Member

PRs usually get merged before an update comes out. We update whenever we think one is needed or we have time. I will check these quests in game likely later today and if I think they’re good I’ll approve this PR.

@pietro-lopes
Copy link
Contributor

this is in no way a "please accept my changes" but how long generally does it take for pull request to get added or denied? ive never been a part of this process before and id like to know

You can always click to requests for a review so this shows that you are already done with the PR

@TheBedrockMaster
Copy link
Member

Or just not having it be a draft shows that it’s done.

@KingofSpiders13
Copy link
Author

ok thanks

@hyodocraft
Copy link
Contributor

The quest 076A648E3E3245C9 (Emerald Generator) has the wrong title (Emerald Furnace).
Also for 0ADBE90B33ACC9FB.title, it's Generator, not Generater.

I’m really looking forward to those changes related to the Occultism quests. However, it seems like there are quite a few changes outside of Occultism as well.
I’m not very familiar with using GitHub features, too, but it might be a good idea to separate the pull request for the Occultism-related changes from the pull request for the other changes.

@TheBedrockMaster
Copy link
Member

One of the commits removed lang edits that came from the last few updates

@KingofSpiders13
Copy link
Author

One of the commits removed lang edits that came from the last few updates

How do I fix this? I didn't realize this had happened and I don't know what to do. It's been a bit since I've worked on this.

@TheBedrockMaster
Copy link
Member

It'll be easiest to remake the PR... again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants