-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reworked Occultism Quests #2309
base: main
Are you sure you want to change the base?
Conversation
I'm going to see if this works but I might not be able to import these correctly (I would therefore be leaving them out)
I was able to fully integrate TheBedrockMaster's changes to the new code.
this is in no way a "please accept my changes" but how long generally does it take for pull request to get added or denied? ive never been a part of this process before and id like to know |
PRs usually get merged before an update comes out. We update whenever we think one is needed or we have time. I will check these quests in game likely later today and if I think they’re good I’ll approve this PR. |
You can always click to requests for a review so this shows that you are already done with the PR |
Or just not having it be a draft shows that it’s done. |
ok thanks |
The quest 076A648E3E3245C9 (Emerald Generator) has the wrong title (Emerald Furnace). I’m really looking forward to those changes related to the Occultism quests. However, it seems like there are quite a few changes outside of Occultism as well. |
One of the commits removed lang edits that came from the last few updates |
How do I fix this? I didn't realize this had happened and I don't know what to do. It's been a bit since I've worked on this. |
It'll be easiest to remake the PR... again. |
I re-did the pull request after the base code was apparently flawed.
Thanks to TheBedrockMaster for helping me with this.
List of changes: