Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/revise fix and relative TableHeaderColumn width issue #1448

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bbbbighead
Copy link

fix table header width adjustment logic when TableHeaderColumn is using fix with or relative width(in percentage %)

  • no need to re-calculate and using fix width when scroll is happening, it will cause side effect which will make header width will only grow but not restore to original size when you resize outside window size(drag window large and small back and forth)

  • please check the video for how to duplicate the issue
    https://youtu.be/-vfrWEJyung

…ng fix with or relative width(in percentage %)

 - no need to re-calculate and using fix width when scroll is happening, it will cause side effect which will make header width will only grow but not restore to original size when you resize outside window size(drag window large and small back and forth)
@AllenFang
Copy link
Owner

@bbbbighead, you found a known issue, actually, I sacrifice this issues to solve most of unalign issues(although there's still have another unalign issues still there....)

it's a long story that I will not to describe again lol, but we have a lots of unalign issues due to react-bootstrap-table use two div with table to construct a bootstrap table instead of a native table tag, so the code you remove is try to solve some unalign issues.

So I can't merge you PR due to it will cause a lots of unalign issue again.... it's very sorry for you...

@bbbbighead
Copy link
Author

hi @AllenFang , got it! Is there any plan when or which version will un-align issues be fixed? v4.0? or other version.

Or....is there any idea you want to fix this issue? Our team is using your component quite a long time and feel very great about it. Could you could give me some clues and maybe we might provide some helps for this issue.

Thanks for the reply and the effort you made for react community.
Taiwan No.1 !!!

@AllenFang
Copy link
Owner

AllenFang commented Jul 10, 2017

Thanks you @bbbbighead 🇹🇼

actually, I usually cant reproduce the unalign issues... and for me, if we want to fix unalign issue thoroughly, the only solution is use one table instead of two div with table, but in single table structure, it's hard to achieve the horizontal and vertical scroll, particular have both at the same time.
Also it's a big change

I'm not even think that I can fix it in the future lol
I've plan to rebuilt react-bootstrap-table as react-bootstrap-table2, which is a new package for replacing react-bootstrap-table but I think I don't have too much time, and it can't be done only by myself.

Anyway, how about I provide a props for you to let you can control if enable/disable width adjusting?
Let me know your concern or question, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants