Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer #554

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Footer #554

wants to merge 4 commits into from

Conversation

r1g0
Copy link
Contributor

@r1g0 r1g0 commented Jul 8, 2016

Hello, I added a footer. To show it there needs to be set a showFooter={ true } as props.

When showFooter is true it shows the same text in the header in the footer unless a footerText='something' is set and then it preffers that one.

I created a TableFooter from the TableHeader and removed the sorting and filtering components.

And also added an example.

@AllenFang
Copy link
Owner

@r1g0, thanks :) I'll check it out. If it's worth to merge, I'll ask you merge into v3.0.0-dev branch

@AllenFang
Copy link
Owner

Ref #497, dont forget to review this PR

import React, { Component, PropTypes } from 'react';
import classSet from 'classnames';

class TableHeader extends Component {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If its a tablefooter than class name should be TableFooter rather than TableHeader

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants