Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing path and circular imports #830

Merged
merged 5 commits into from
Aug 9, 2022
Merged

Fixing path and circular imports #830

merged 5 commits into from
Aug 9, 2022

Conversation

alexpiet
Copy link
Collaborator

@alexpiet alexpiet commented Aug 8, 2022 •
edited
Loading

  • Fixes a path issue Path issues #829
  • Fixes a circular import Circular import problem #831
    • I do this by removing the import of visual_behavior.visualization.behavior which breaks the function visual_behavior.utilities.cache_response_probability()
    • I specifically am not fixing the linting issue caused by removing this import

matchings
matchings approved these changes Aug 9, 2022
View reviewed changes
Copy link
Collaborator

@matchings matchings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you Alex!

@alexpiet alexpiet merged commit a0b0ce5 into master Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matchings matchings matchings approved these changes

@yavorska-iryna yavorska-iryna Awaiting requested review from yavorska-iryna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexpiet @matchings