Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow hosting PyOCI on a subpath #142

Merged
merged 1 commit into from
Jan 9, 2025
Merged

feat: Allow hosting PyOCI on a subpath #142

merged 1 commit into from
Jan 9, 2025

Conversation

AllexVeldman
Copy link
Owner

When environment variable PYOCI_PATH is set, all URLs are resolved as a subpath of PYOCI_PATH.
This is also reflected in the links provided by list_packages.

closes: #141

@AllexVeldman AllexVeldman added the enhancement New feature or request label Jan 9, 2025
@AllexVeldman AllexVeldman self-assigned this Jan 9, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.41584% with 8 lines in your changes missing coverage. Please review.

Project coverage is 96.08%. Comparing base (090f520) to head (2ab3764).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/main.rs 12.50% 7 Missing ⚠️
src/app.rs 99.79% 1 Missing ⚠️
Additional details and impacted files

@AllexVeldman
feat: Allow hosting PyOCI on a subpath
2ab3764 
When environment variable `PYOCI_PATH` is set, all URLs are resolved as
a subpath of `PYOCI_PATH`.
This is also reflected in the links provided by `list_packages`.

closes: #141
@AllexVeldman AllexVeldman merged commit 328044e into main Jan 9, 2025
4 checks passed
@AllexVeldman AllexVeldman deleted the feat/subpath branch January 9, 2025 11:02
@github-actions github-actions bot mentioned this pull request Jan 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AllexVeldman AllexVeldman

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow serving PyOCI on a subpath
1 participant
@AllexVeldman