refactor: Implement log and authentication as tower::Layer
#23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR moves the sub-request logging and authentication to their own `tower::Layer` middleware. `HttpTransport` is now a `Service<reqwest::Request>` that we can apply `tower::Layer` implementations on. Currently I `Pin<Box<>>` the reqwest execute future and the authentication future. boxing the authentication future should be fine as it will only happen once per request. boxing the reqwest execute future might benefit from not having to be boxed as we can send multiple subrequests per request, will have to figure our how to do that at some point in the future (pun intended =).
Codecov ReportAttention: Patch coverage is
Additional details and impacted files📢 Thoughts on this report? Let us know! |
If the provided auth String can't be used as a header value, return Err.
Minimizes the trait bounds in the auth module. Strict bounds to reqwest::Request are now only defined on the Service and Future impls, saving a lot of repetition.
The AuthService and AuthFuture are now setup to return anyhow errors. This allows specific error handling through downcasting in app.rs if needed. For now all errors we can't fall back to a response for will return a server error.
Ensure we return BAD_GATEWAY during authentication when the error is due to an upstream server
AllexVeldman
force-pushed
the
tower-service
branch
from
cc7d980 to
8249a1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the sub-request logging and authentication to their own
tower::Layermiddleware.HttpTransportis now aService<reqwest::Request>that we can applytower::Layerimplementations on.Currently I
Pin<Box<>>the reqwest execute future and theauthentication future. Boxing the authentication future should be fine
as it will only happen once per request. boxing the reqwest execute
future might benefit from not having to be boxed as we can send multiple
subrequests per request, will have to figure
our how to do that at some point in the future (pun intended =).
Additionally some cases during authentication, where the upstream server caused an error, I now return 502 Bad Gateway instead of 500 or the upstream response.