feat!: Drop WASM target, add Docker #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllexVeldman
force-pushed
the
docker
branch
from
37df2b9 to
a4519a6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files📢 Thoughts on this report? Let us know! |
AllexVeldman
force-pushed
the
docker
branch
3 times, most recently
from
d469b7e to
108c7ed
Compare
AllexVeldman
had a problem deploying
to
pyoci.com
GitHub Actions
Failure
AllexVeldman
had a problem deploying
to
pyoci.com
GitHub Actions
Failure
AllexVeldman
force-pushed
the
docker
branch
from
781c8dc to
508367d
Compare
AllexVeldman
had a problem deploying
to
pyoci.com
GitHub Actions
Failure
AllexVeldman
force-pushed
the
docker
branch
from
508367d to
b290b0a
Compare
AllexVeldman
had a problem deploying
to
pyoci.com
GitHub Actions
Failure
AllexVeldman
force-pushed
the
docker
branch
from
b290b0a to
a5338f7
Compare
AllexVeldman
had a problem deploying
to
pyoci.com
GitHub Actions
Failure
AllexVeldman
had a problem deploying
to
pyoci.com
GitHub Actions
Failure
AllexVeldman
had a problem deploying
to
pyoci.com
GitHub Actions
Failure
AllexVeldman
had a problem deploying
to
pyoci.com
GitHub Actions
Failure
AllexVeldman
temporarily deployed
to
pyoci.com
GitHub Actions
Inactive
AllexVeldman
force-pushed
the
docker
branch
2 times, most recently
from
6c26ce5 to
5ef3ecf
Compare
|
Instead of Google Cloud Run, Azure Container Apps might make sense. https://azure.microsoft.com/en-us/products/container-apps#Pricing Google free tier:
Azure free tier:
Main benefit is that Azure allows providing an origin certificate so I can keep cloudflare in front for DDOS mitigation and CDN cache (once needed) where google can do custom domain mapping, requiring the use of the google cert or adding a load balancer in front, which does not have a free tier. |
AllexVeldman
had a problem deploying
to
pyoci.com
GitHub Actions
Failure
AllexVeldman
had a problem deploying
to
pyoci.com
GitHub Actions
Failure
AllexVeldman
had a problem deploying
to
pyoci.com
GitHub Actions
Failure
This removes WASM (and as a result cloudflare) as the deployment target. Instead this builds a docker container to deploy anywhere. Tokio now takes care of the async runtime, flushing of OTLP is handled by a background task, every second, instead of every request. The list-package endpoint's `href`'s will now use relative paths, not sure how I missed this was an option. The `href`'s also no longer urlencode "https://" This prevents issues when running behind proxies that url-decode requests before hitting our server. The url encoding stays in place so we can locally use http instead of https. It can still happen that some registries are incorrectly decoded and passed on to our server, potential problem for future me.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes WASM (and as a result cloudflare) as the deployment target. Instead this builds a docker container to deploy anywhere.
Tokio now takes care of the async runtime, flushing of OTLP is handled by a background task, every second, instead of every request.
The list-package endpoint's
href's will now use relative paths, not sure how I missed this was an option.