Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft of the Branding page #618

Draft
wants to merge 2 commits into
base: staging
Choose a base branch
from

Conversation

sboldyreva
Copy link
Collaborator

This is a draft of the branding page:

  • Can be reached from Resources
  • Information is taken from the current Brandbook and needs verification
  • Some information is still present only in the brandbook (misuse examples, space examples, etc) so I put a link to download the full version

Issues:

  • Not all logos/icons have a corresponding SVG file in the repo yet, some are PNGs
  • Responsive design is not fixed yet!
  • We mention AlmaLinux Terms of Service, AlmaLinux OS End User Agreement and Privacy Policy in the brandbook/page. In this case I believe we should add correct links there.

@jonathanspw
Copy link
Member

@bennyvasquez
Copy link
Member

I love, love, love the idea of this overall, but I want to get us away from using in-line CSS completely, and moving the CSS into the CSS files (/assets/css/bundle.css). I'd also like us to start controlling sizing and padding using bootstrap's built in options (for example sizing and spacing). It allows us to be more consistent across the site, and it automatically and immediately makes responsiveness easier and better.

There's a learning curve to it as you get started, but having just broken a bunch of stuff with ALESCo, and then spent the time learning it with the certification stuff I can say for sure it helps a ton.

@bennyvasquez bennyvasquez added the enhancement New feature or request label Sep 10, 2024
@bennyvasquez
Copy link
Member

@sboldyreva I don't remember where we left this. Were you going to work on the suggestions before I merged this into staging, or was I going to merge this into staging and then we could work on it together from there?

@sboldyreva sboldyreva changed the base branch from master to staging September 24, 2024 11:03
@sboldyreva
Copy link
Collaborator Author

@bennyvasquez I just rebased the pr to staging so it could be merged! It can be merged and meanwhile I'm going to start working on the suggestions :)

@sboldyreva
Copy link
Collaborator Author

@bennyvasquez moved css to bundle.css

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants