-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft of the Branding page #618
base: staging
Are you sure you want to change the base?
Conversation
I love, love, love the idea of this overall, but I want to get us away from using in-line CSS completely, and moving the CSS into the CSS files (/assets/css/bundle.css). I'd also like us to start controlling sizing and padding using bootstrap's built in options (for example sizing and spacing). It allows us to be more consistent across the site, and it automatically and immediately makes responsiveness easier and better. There's a learning curve to it as you get started, but having just broken a bunch of stuff with ALESCo, and then spent the time learning it with the certification stuff I can say for sure it helps a ton. |
@sboldyreva I don't remember where we left this. Were you going to work on the suggestions before I merged this into staging, or was I going to merge this into staging and then we could work on it together from there? |
@bennyvasquez I just rebased the pr to staging so it could be merged! It can be merged and meanwhile I'm going to start working on the suggestions :) |
@bennyvasquez moved css to bundle.css |
This is a draft of the branding page:
Issues: