Skip to content

Commit

Permalink
Fix/bounds (#59)
Browse files Browse the repository at this point in the history

* fixing bug in finding pipeline names and removing extra debug statements
  • Loading branch information
mclarsen authored Dec 20, 2017
1 parent e9ec1ac commit 3a04c4a
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 12 deletions.
12 changes: 6 additions & 6 deletions src/ascent/runtimes/ascent_main_runtime.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ AscentRuntime::ConvertToFlowGraph(const conduit::Node &pipeline,
// can connect to the end result by pipeline name
w.graph().add_filter("alias",
pipeline_name);

w.graph().connect(prev_name, // src
pipeline_name, // dest
0); // default port
Expand Down Expand Up @@ -436,7 +436,7 @@ AscentRuntime::ConvertExtractToFlow(const conduit::Node &extract,
// this is the blueprint mesh
extract_source = "source";
}
std::cout<<"***** extract source : "<<extract_source<<"\n";

m_connections[ensure_name] = extract_source;
m_connections[extract_name] = ensure_name;

Expand Down Expand Up @@ -531,9 +531,9 @@ AscentRuntime::GetPipelines(const conduit::Node &plots)
{
conduit::Node plot = plots.child(i);
std::string pipeline;
if(plot.has_path("params/pipeline"))
if(plot.has_path("pipeline"))
{
pipeline = plot["params/pipeline"].as_string();
pipeline = plot["pipeline"].as_string();
}
else
{
Expand Down Expand Up @@ -617,7 +617,7 @@ AscentRuntime::CreateScenes(const conduit::Node &scenes)
1); // default port

// ------------ NEW -----------------

std::vector<std::string> pipelines = GetPipelines(scene["plots"]);
std::vector<std::string> plot_names = scene["plots"].child_names();

Expand Down Expand Up @@ -775,7 +775,7 @@ AscentRuntime::CreateScenes(const conduit::Node &scenes)
bounds_output = union_bounds_names[union_size-1];
domain_ids_output = union_domain_ids_names[union_size-1];
}

w.graph().connect(bounds_output, // src
renders_name, // dest
0); // default port
Expand Down
10 changes: 4 additions & 6 deletions src/ascent/runtimes/flow_filters/ascent_runtime_vtkh_filters.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -871,7 +871,7 @@ VTKHSlice::verify_params(const conduit::Node &params,
{
info.reset();
bool res = true;
params.print();

if(! params.has_path("point/x") ||
! params["point/y"].dtype().is_number() )
{
Expand Down Expand Up @@ -945,7 +945,7 @@ VTKHSlice::execute()
slicer.Update();

vtkh::DataSet *slice_output = slicer.GetOutput();

set_output<vtkh::DataSet>(slice_output);
}

Expand Down Expand Up @@ -1102,7 +1102,7 @@ DefaultRender::execute()
std::copy(domain_ids->begin(), domain_ids->end(), v_domain_ids.begin());

std::vector<vtkh::Render> *renders = new std::vector<vtkh::Render>();

if(params().has_path("renders"))
{
const conduit::Node renders_node = params()["renders"];
Expand Down Expand Up @@ -1356,7 +1356,6 @@ VTKHBounds::execute()

vtkh::DataSet *data = input<vtkh::DataSet>(0);
bounds->Include(data->GetGlobalBounds());

set_output<vtkm::Bounds>(bounds);
}

Expand Down Expand Up @@ -1404,7 +1403,6 @@ VTKHUnionBounds::execute()
vtkm::Bounds *bounds_a = input<vtkm::Bounds>(0);
vtkm::Bounds *bounds_b = input<vtkm::Bounds>(1);


result->Include(*bounds_a);
result->Include(*bounds_a);

Expand Down Expand Up @@ -1678,7 +1676,7 @@ CreatePlot::verify_params(const conduit::Node &params,
info["errors"].append() = "Missing required string parameter 'type'";
res = false;
}
params.print();

if(! params.has_child("params") )
{
info["errors"].append() = "Missing required parameter 'params'";
Expand Down

0 comments on commit 3a04c4a

Please sign in to comment.