add tubes for rendering streamlines #1239
Conversation
… it's ascents fault
… filter, maybe should switch that around
…g' of https://github.com/Alpine-DAV/ascent into task/2023_12_vtkm_add_tubes_for_particle_advec_rendering
| else | ||
| dz = dist_z/num_seeds_z; | ||
|
|
||
| double epsilon = 0.1; |
There was a problem hiding this comment.
I was struggling to render seeds that are directly on the boundary, so I've been offsetting all my points my epsilon.
Note for later for picking a better epsilon:
vtkm::Float64 lx = coordBounds.X.Length();
vtkm::Float64 ly = coordBounds.Y.Length();
vtkm::Float64 lz = coordBounds.Z.Length();
vtkm::Float64 mag = vtkm::Sqrt(lx * lx + ly * ly + lz * lz);
// same as used in vtk ospray
constexpr vtkm::Float64 heuristic = 1000.;
radius = static_castvtkm::Float32(mag / heuristic);
m_tube_size = radius;
There was a problem hiding this comment.
So I understand: Is it that the box is exactly aligned a data set boundary causing numeric sadness?
If so, the user could adjust the box to not be aligned. Box params being correct is something user can control.
There was a problem hiding this comment.
Exactly, anything on the boundary needs to be moved slightly or else we lose the particles.
I guess the check should be if the particle is on the boundary and then adjust, rather than adjusting ALL points like I am.
Here are boundary points that are not and are adjusted using epsilon, respectively.
…g' of https://github.com/Alpine-DAV/ascent into task/2023_12_vtkm_add_tubes_for_particle_advec_rendering
|
looks great, can we change the file names of the tests to be a more descriptive: for example, from:
to
|
oops, I meant to delete these. But they should also pass the windows tests no problem. I'll add them . Good catch! |
| // scene.AddRender(render); | ||
| // scene.AddRenderer(&tracer); | ||
| // scene.Render(); | ||
| // |
There was a problem hiding this comment.
Should we turn this back on?
If so, lets add a ticket to track.
| // vtkh::Scene scene; | ||
| // scene.AddRender(render); | ||
| // scene.AddRenderer(&tracer); | ||
| // scene.Render(); |
Sounds good! I'll make a ticket for the warpx tests |
Apply the VTK-m Tube filter to the output of the Streamline filters to allow for rendering