Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for customizable installation directory #1250

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

mvictoras
Copy link
Contributor

This pull request modifies the existing bash script for compiling and installing Ascent to introduce flexibility in the installation directory. Previously, the script installed Ascent at ${root_dir}/install by default. However, with this change, users can now define their own installation directory using the environment variable ${install_dir}.

By allowing users to specify their preferred installation path, this update enhances the usability of the script and accommodates diverse user requirements. Whether installing Ascent for personal projects or system-wide use, users now have the freedom to choose where Ascent is installed, providing greater control over their development environments.

Copy link
Member

@cyrush cyrush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for the improvement

@cyrush cyrush merged commit ae3380a into Alpine-DAV:develop Feb 22, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants