-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add terminal-based steering interface via an extract #1345
Changes from 3 commits
20abd1e
4cd5fd0
f94bda4
fe8cda3
bb61ae2
11197e0
53823b5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -87,6 +87,14 @@ void ASCENT_API execute_callback(std::string callback_name, | |||||
//----------------------------------------------------------------------------- | ||||||
bool ASCENT_API execute_callback(std::string callback_name); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
||||||
//----------------------------------------------------------------------------- | ||||||
std::vector<std::string> | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ref copy out style will be slight more efficient:
|
||||||
ASCENT_API get_void_callbacks(); | ||||||
|
||||||
//----------------------------------------------------------------------------- | ||||||
std::vector<std::string> | ||||||
ASCENT_API get_bool_callbacks(); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ref copy out style will be slight more efficient:
|
||||||
|
||||||
//----------------------------------------------------------------------------- | ||||||
void ASCENT_API reset_callbacks(); | ||||||
|
||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copy out still ref args are a bit more efficient (see below)