Relay Extract: Silo/Overlink #1377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustinPrivitera
commented
Aug 30, 2024
cyrush
requested changes
Sep 3, 2024
| { | ||
| error = 1; | ||
| error_oss << "relay_io_save Overlink save requires a single topology; " | ||
| "there are " << num_topos << " topologies in the input mesh."; |
There was a problem hiding this comment.
for the error case, lets show them all the unique topology names as part of the error message, and also tell them the param name that they can use to select the topology.
There was a problem hiding this comment.
How does this look?
[Error] Ascent::execute
file: /usr/workspace/justin/ascent_builds/develop_08_22_24/ascent/src/libs/ascent/runtimes/flow_filters/ascent_runtime_relay_filters.cpp
line: 872
message:
relay_io_save Overlink save requires a single topology; there are 3 topologies in the input mesh. The current topologies are
- topo
- topo2
- topo3
You can select which topologies to save using the "topologies" parameter like in the following example:
extracts["<extract_name>/params/topologies"].append() = "<topo_name>"
| } | ||
| else | ||
| { | ||
| // cyrus was wrong about 2 mpi ranks. |
There was a problem hiding this comment.
it lives on, across projects, space, and time
cyrush
approved these changes
Sep 4, 2024
|
Looks good! |
JustinPrivitera
deleted the
task/JustinPrivitera/08_28_24/silo_extract
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.