Random Button in every companion plot menue #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lang folder needs to be deleted for the files to update. Interrupt the thread when an error happens. Closes #25.
To improve Code Quality. Also Apply NotNull annotation and remove unused language key.
Remove FaweAPI call in favor of native api, which handles streams properly. Also remove deprecated getMinecraftCoordinates method. And remove non-necessary method getDescriptionComponents.
Try to split the code to make it more readable.
|
Could you elaborate on "the language file doesnt automatically update"? |
I thought, we have a system in-place, so when new language keys gets added to the plugin, and we bump the config version, they will also be copied to already existing languages files? If yes, this is not the case. The language file stays the same, with the old keys + values. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #25.
Currently, I couldn't test the Continent Menu: all other works fine. The language file doesn't automatically update: maybe we need to fix this in another repo?
This PR does also include Code Improvements + a small bug fix.