Remove modelId parameter from setModelDataType method

Altinn · Dec 18, 2024 · d3374b5 · d3374b5
1 parent 58884cd
commit d3374b5
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/backend/src/Designer/Controllers/DatamodelsController.cs b/backend/src/Designer/Controllers/DatamodelsController.cs
@@ -265,9 +265,9 @@ public async Task<IActionResult> GetModelDataType(string org, string repository,
         /// </summary>
         [HttpPut("datamodel/{modelName}/dataType")]
         [UseSystemTextJson]
-        public async Task SetModelDataType(string org, string repository, string modelName, [FromBody] DataType dataType)
+        public async Task SetModelDataType(string org, string repository, [FromBody] DataType dataType)
         {
-            await _schemaModelService.SetModelDataType(org, repository, modelName, dataType);
+            await _schemaModelService.SetModelDataType(org, repository, dataType);
         }
 
         private static string GetFileNameFromUploadedFile(IFormFile thefile)

diff --git a/backend/src/Designer/Services/Implementation/SchemaModelService.cs b/backend/src/Designer/Services/Implementation/SchemaModelService.cs
@@ -443,10 +443,10 @@ public async Task<DataType> GetModelDataType(string org, string app, string mode
             return dataType;
         }
 
-        public async Task SetModelDataType(string org, string app, string modelId, DataType dataType)
+        public async Task SetModelDataType(string org, string app, DataType dataType)
         {
             ApplicationMetadata applicationMetadata = await _applicationMetadataService.GetApplicationMetadataFromRepository(org, app);
-            applicationMetadata.DataTypes.RemoveAll((dataType) => dataType.Id == modelId);
+            applicationMetadata.DataTypes.RemoveAll((dt) => dt.Id == dataType.Id);
             applicationMetadata.DataTypes.Add(dataType);
             await _applicationMetadataService.UpdateApplicationMetaDataLocally(org, app, applicationMetadata);
         }

diff --git a/backend/src/Designer/Services/Interfaces/ISchemaModelService.cs b/backend/src/Designer/Services/Interfaces/ISchemaModelService.cs
@@ -93,6 +93,6 @@ public interface ISchemaModelService
         /// <summary>
         /// Updates the dataType for a given model.
         /// </summary>
-        Task SetModelDataType(string org, string app, string modelId, DataType dataType);
+        Task SetModelDataType(string org, string app, DataType dataType);
     }
 }