Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix form validation of version control #10767

Closed
2 tasks done
Tracked by #10762
mlqn opened this issue Aug 8, 2023 · 6 comments · Fixed by #11871
Closed
2 tasks done
Tracked by #10762

Fix form validation of version control #10767

mlqn opened this issue Aug 8, 2023 · 6 comments · Fixed by #11871
Labels
added-to-sprint area/version-control Area: Related to version control for files in apps. kind/bug Used when there is a defect / something is not working as it should. kind/user-story Used for issues that describes functionality for our users. status/triage

Comments

@mlqn
Copy link
Contributor

mlqn commented Aug 8, 2023

Wrong error message when validation fails because of an existing number version

Screen.Recording.2023-09-11.at.14.22.36.mov

I also suggest wrapping all form fields with the new FormField component to maintain consistent styling for error messages.

Screenshot 2023-08-08 at 08 26 14

Tasks

Preview Give feedback
@mlqn mlqn added kind/user-story Used for issues that describes functionality for our users. kind/bug Used when there is a defect / something is not working as it should. status/triage area/version-control Area: Related to version control for files in apps. labels Sep 25, 2023
@nkylstad nkylstad moved this to 📈 Todo in Team Studio Oct 23, 2023
@JamalAlabdullah JamalAlabdullah moved this from 📈 Todo to 👷 In Progress in Team Studio Dec 12, 2023
@JamalAlabdullah JamalAlabdullah moved this from 👷 In Progress to 📈 Todo in Team Studio Dec 12, 2023
@JamalAlabdullah JamalAlabdullah moved this from 📈 Todo to 👷 In Progress in Team Studio Dec 14, 2023
@JamalAlabdullah JamalAlabdullah self-assigned this Dec 14, 2023
@JamalAlabdullah JamalAlabdullah linked a pull request Dec 15, 2023 that will close this issue
5 tasks
@JamalAlabdullah JamalAlabdullah moved this from 👷 In Progress to 🔎 Review in Team Studio Dec 15, 2023
@JamalAlabdullah JamalAlabdullah removed their assignment Dec 15, 2023
@mlqn mlqn assigned mlqn and unassigned mlqn Dec 15, 2023
@github-project-automation github-project-automation bot moved this from 🔎 Review to 🧪 Test in Team Studio Dec 20, 2023
@ghost
Copy link

ghost commented Dec 20, 2023

I tested this now, the validation works ok as expected, but it seems to be some errors on the page that are related to the field having an error. I've checked in prod and the error is there too, so I would recommend to either include it in this issue or create a new to fix it 😄

Screen.Recording.2023-12-20.at.13.01.42.mov

@ghost ghost moved this from 🧪 Test to 👀 Test feedback in Team Studio Dec 20, 2023
@mlqn
Copy link
Contributor Author

mlqn commented Dec 20, 2023

@WilliamThorenfeldt Are you referring to the red error message? If so, it appears because you entered an @ symbol, while the version number can only contain 0-9, a-z, ., or -.

@mlqn
Copy link
Contributor Author

mlqn commented Dec 20, 2023

Ah, I think I see what problem you are referring to, it's the width of the sidebar that changes when the error message appears? I also agree that it would be nice to fix it 👍

@ghost
Copy link

ghost commented Dec 20, 2023

The width yes, it bounces when I type something illegal

@JamalAlabdullah
Copy link
Contributor

JamalAlabdullah commented Dec 21, 2023

This problem was actually before this fixing. I suggest fixing it as a separate issue because it is something related to style for the entire page, not validation. I can make an issue for this.

@ghost
Copy link

ghost commented Dec 21, 2023

This problem was actually before this fixing. I suggest fixing it as a separate issue because it is something related to style for the entire page, not validation. I can make an issue for this.

I agree 😄

@JamalAlabdullah JamalAlabdullah moved this from 👀 Test feedback to ✅ Done in Team Studio Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added-to-sprint area/version-control Area: Related to version control for files in apps. kind/bug Used when there is a defect / something is not working as it should. kind/user-story Used for issues that describes functionality for our users. status/triage
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants