-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix form validation of version control #10767
Comments
I tested this now, the validation works ok as expected, but it seems to be some errors on the page that are related to the field having an error. I've checked in prod and the error is there too, so I would recommend to either include it in this issue or create a new to fix it 😄 Screen.Recording.2023-12-20.at.13.01.42.mov |
@WilliamThorenfeldt Are you referring to the red error message? If so, it appears because you entered an |
Ah, I think I see what problem you are referring to, it's the width of the sidebar that changes when the error message appears? I also agree that it would be nice to fix it 👍 |
The width yes, it bounces when I type something illegal |
This problem was actually before this fixing. I suggest fixing it as a separate issue because it is something related to style for the entire page, not validation. I can make an issue for this. |
I agree 😄 |
Wrong error message when validation fails because of an existing number version
Screen.Recording.2023-09-11.at.14.22.36.mov
I also suggest wrapping all form fields with the new FormField component to maintain consistent styling for error messages.
Tasks
The text was updated successfully, but these errors were encountered: