Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

10767 fix form validation of version control #11871

Merged
merged 2 commits into from
Dec 20, 2023
Merged

10767 fix form validation of version control #11871

merged 2 commits into from
Dec 20, 2023

Conversation

JamalAlabdullah
Copy link
Contributor

@JamalAlabdullah JamalAlabdullah commented Dec 15, 2023 •
edited
Loading

Description

  • Fixed error message type by adding an own error mesage when the version number is already exists.
  • Wrapped input fields with FormField. to implement its style for the error message.
  • Replaced LegacyTextField and LegacyTextArea with Textfield, and Textarea.

Related Issue(s)

Verification

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@JamalAlabdullah JamalAlabdullah linked an issue Dec 15, 2023 that may be closed by this pull request
Fix form validation of version control #10767
Closed
@github-actions github-actions bot added area/app-deploy Area: Related to deploying apps from Altinn Studio to Altinn Apps. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Dec 15, 2023
mlqn
mlqn approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@mlqn mlqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 👍

@JamalAlabdullah JamalAlabdullah merged commit e15b4c1 into master Dec 20, 2023
10 checks passed
@JamalAlabdullah JamalAlabdullah deleted the 10767-fix-form-validation-of-version-control branch December 20, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlqn mlqn mlqn approved these changes

Assignees
No one assigned
Labels
area/app-deploy Area: Related to deploying apps from Altinn Studio to Altinn Apps. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix form validation of version control
2 participants
@JamalAlabdullah @mlqn