Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10898 New contact page #11531

Merged
merged 31 commits into from
Nov 24, 2023
Merged

10898 New contact page #11531

merged 31 commits into from
Nov 24, 2023

Conversation

mlqn
Copy link
Contributor

@mlqn mlqn commented Nov 7, 2023

Description

  • New Contact page
  • New footer on the Overview page with a link pointing to the new Contact page
  • New link in error messages pointing to the new Contact page
  • New package called studio-root that will handle all top-level routes except for /designer and those that already are handled like /dashboard, /editor, /resourceadm, /preview, etc.
  • Moved NotFoundPage.tsx from app-development to packages/shared to handle non-existing routes in studio-root
  • Updated Header.tsx to make it work with unauthenticated users

New footer of the Overview page

footer

New Contact page

contact

Related Issue(s)

Verification

@github-actions github-actions bot added area/dashboard Area: Related to the dashboard application solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Nov 7, 2023
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e59bfdf) 83.70% compared to head (07016ad) 83.72%.
Report is 9 commits behind head on master.

❗ Current head 07016ad differs from pull request most recent head 2d82bc5. Consider uploading reports for the commit 2d82bc5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11531      +/-   ##
==========================================
+ Coverage   83.70%   83.72%   +0.02%     
==========================================
  Files         883      885       +2     
  Lines       13052    13070      +18     
  Branches     1711     1712       +1     
==========================================
+ Hits        10925    10943      +18     
  Misses       1868     1868              
  Partials      259      259              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot removed the area/dashboard Area: Related to the dashboard application label Nov 9, 2023
@mlqn mlqn force-pushed the 10898-contact-page branch from c418704 to 87dbac9 Compare November 9, 2023 17:04
@github-actions github-actions bot added quality/testing Tests that are missing, needs to be created or could be improved. skip-releasenotes Issues that do not make sense to list in our release notes kind/dependencies Used for issues or pull requests that are dependency updates labels Nov 13, 2023
@mlqn mlqn linked an issue Nov 15, 2023 that may be closed by this pull request
@github-actions github-actions bot added the area/dashboard Area: Related to the dashboard application label Nov 16, 2023
@mlqn mlqn marked this pull request as ready for review November 20, 2023 08:20
Copy link
Member

@nkylstad nkylstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good!
I tested the branch, and had a few issues.
First, when I went to the contact page from the app overview page, clicking the back button in the browser sent me to dashboard, and not back to the app overview page. Was able to reproduce this quite consistently for a short while, and then it worked as expected 😅 Something to test for in dev maybe.
Also seem to be some issues with the text/link in the toast error message.

frontend/language/src/en.json Show resolved Hide resolved
frontend/language/src/nb.json Show resolved Hide resolved
@mlqn
Copy link
Contributor Author

mlqn commented Nov 23, 2023

I couldn't reproduce the redirection issue either. It might be a caching problem here as well, I'm not really sure 🤔

@mlqn mlqn requested a review from nkylstad November 23, 2023 12:08
Copy link
Member

@nkylstad nkylstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@mlqn mlqn merged commit d76cbaa into master Nov 24, 2023
9 checks passed
@mlqn mlqn deleted the 10898-contact-page branch November 24, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard Area: Related to the dashboard application kind/dependencies Used for issues or pull requests that are dependency updates quality/testing Tests that are missing, needs to be created or could be improved. skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create new contact page
3 participants