-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
10898 New contact page #11531
10898 New contact page #11531
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11531 +/- ##
==========================================
+ Coverage 83.70% 83.72% +0.02%
==========================================
Files 883 885 +2
Lines 13052 13070 +18
Branches 1711 1712 +1
==========================================
+ Hits 10925 10943 +18
Misses 1868 1868
Partials 259 259 ☔ View full report in Codecov by Sentry. |
c418704
to
87dbac9
Compare
* Fix header for unauthenticated users
47c2c15
to
2d82bc5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks good!
I tested the branch, and had a few issues.
First, when I went to the contact page from the app overview page, clicking the back button in the browser sent me to dashboard, and not back to the app overview page. Was able to reproduce this quite consistently for a short while, and then it worked as expected 😅 Something to test for in dev maybe.
Also seem to be some issues with the text/link in the toast error message.
I couldn't reproduce the redirection issue either. It might be a caching problem here as well, I'm not really sure 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
studio-root
that will handle all top-level routes except for/designer
and those that already are handled like/dashboard
,/editor
,/resourceadm
,/preview
, etc.NotFoundPage.tsx
fromapp-development
topackages/shared
to handle non-existing routes instudio-root
Header.tsx
to make it work with unauthenticated usersNew footer of the Overview page
New Contact page
Related Issue(s)
Verification