Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/11502 bpmn palette icons #11654

Closed
wants to merge 29 commits into from
Closed

Conversation

nkylstad
Copy link
Member

@nkylstad nkylstad commented Nov 23, 2023

Description

  • Added icons for palette items using CSS
  • Fixed height issue for BPMN editor

Updated stroke-width of icon svgs to 0.8 to match stroke in the process editor, FYI @Annikenkbrathen
Screenshot 2023-11-23 at 09 55 10

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)

@github-actions github-actions bot added area/dashboard Area: Related to the dashboard application solution/studio/designer Issues related to the Altinn Studio Designer solution. quality/testing Tests that are missing, needs to be created or could be improved. skip-releasenotes Issues that do not make sense to list in our release notes kind/dependencies Used for issues or pull requests that are dependency updates labels Nov 23, 2023
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a0e7fbe) 83.85% compared to head (7b8e4e2) 83.72%.

❗ Current head 7b8e4e2 differs from pull request most recent head 503ed02. Consider uploading reports for the commit 503ed02 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11654      +/-   ##
==========================================
- Coverage   83.85%   83.72%   -0.14%     
==========================================
  Files         883      885       +2     
  Lines       13023    13070      +47     
  Branches     1700     1712      +12     
==========================================
+ Hits        10921    10943      +22     
- Misses       1846     1868      +22     
- Partials      256      259       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nkylstad nkylstad force-pushed the feat/11502-bpmn-palette-icons branch from 7b8e4e2 to 503ed02 Compare November 23, 2023 09:24
@nkylstad nkylstad closed this Nov 23, 2023
@nkylstad nkylstad deleted the feat/11502-bpmn-palette-icons branch November 23, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard Area: Related to the dashboard application kind/dependencies Used for issues or pull requests that are dependency updates quality/testing Tests that are missing, needs to be created or could be improved. skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants