Bug fix/11366 replace altinn menu with dropdown menu at lage page #11779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…downMenu-at-Lage-page
…downMenu-at-Lage-page
ghost
requested review from
mlqn,
TomasEng,
framitdavid,
standeren and
JamalAlabdullah
ghost
linked an issue
github-actions
bot
added
area/ui-editor
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #11779 +/- ##
==========================================
+ Coverage 84.85% 84.87% +0.02%
==========================================
Files 886 887 +1
Lines 13053 13051 -2
Branches 1661 1655 -6
==========================================
+ Hits 11076 11077 +1
+ Misses 1739 1738 -1
+ Partials 238 236 -2 ☔ View full report in Codecov by Sentry. |
framitdavid
approved these changes
Dec 4, 2023
framitdavid
requested changes
Dec 4, 2023
...or/src/containers/DesignView/PageAccordion/NavigationMenu/InputPopover/InputPopover.test.tsx
Show resolved
Hide resolved
...or/src/containers/DesignView/PageAccordion/NavigationMenu/InputPopover/InputPopover.test.tsx
Show resolved
Hide resolved
…downMenu-at-Lage-page
…downMenu-at-Lage-page
TomasEng
requested changes
Dec 7, 2023
...d/packages/ux-editor/src/containers/DesignView/PageAccordion/DeletePopover/DeletePopover.tsx
Outdated
Show resolved
Hide resolved
framitdavid
approved these changes
Dec 8, 2023
…downMenu-at-Lage-page
TomasEng
reviewed
Dec 11, 2023
...-editor/src/containers/DesignView/PageAccordion/NavigationMenu/InputPopover/InputPopover.tsx
Outdated
Show resolved
Hide resolved
...or/src/containers/DesignView/PageAccordion/NavigationMenu/InputPopover/InputPopover.test.tsx
Show resolved
Hide resolved
...ges/ux-editor/src/containers/DesignView/PageAccordion/NavigationMenu/NavigationMenu.test.tsx
Show resolved
Hide resolved
TomasEng
reviewed
Dec 11, 2023
...-editor/src/containers/DesignView/PageAccordion/NavigationMenu/InputPopover/InputPopover.tsx
Show resolved
Hide resolved
...-editor/src/containers/DesignView/PageAccordion/NavigationMenu/InputPopover/InputPopover.tsx
Outdated
Show resolved
Hide resolved
|
@TomasEng, the failing test now is the one we know about from resourceadm |
TomasEng
approved these changes
Dec 13, 2023
ghost
deleted the
bug-fix/11366-replace-AltinnMenu-with-DropdownMenu-at-Lage-page
branch
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AltinnMenuwithDropdownMenuat lage page.PageAccordionRelated Issue(s)
Verification