Compile csharp datamodel before saving #11785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/data-modeling
standeren
force-pushed
the
11461-try-to-compile-c-model-before-saving
branch
from
5ec9f34 to
4a254bf
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11785 +/- ##
==========================================
+ Coverage 84.85% 84.95% +0.09%
==========================================
Files 886 887 +1
Lines 13054 13080 +26
Branches 1661 1664 +3
==========================================
+ Hits 11077 11112 +35
+ Misses 1739 1732 -7
+ Partials 238 236 -2 ☔ View full report in Codecov by Sentry. |
standeren
force-pushed
the
11461-try-to-compile-c-model-before-saving
branch
9 times, most recently
from
7038275 to
df6a2e6
Compare
standeren
force-pushed
the
11461-try-to-compile-c-model-before-saving
branch
3 times, most recently
from
695622f to
3571dcf
Compare
mirkoSekulic
approved these changes
Dec 7, 2023
backend/src/Designer/Services/Implementation/SchemaModelService.cs
Outdated
Show resolved
Hide resolved
|
Seems like there is an issue in the frontend. Docker build fails. |
Yep, there was some errors in a master version that was merged into this branch, but it should be fixed in current master! 😄 |
standeren
force-pushed
the
11461-try-to-compile-c-model-before-saving
branch
2 times, most recently
from
5546c6d to
4b7a637
Compare
github-actions
bot
removed
the
kind/dependencies
standeren
force-pushed
the
11461-try-to-compile-c-model-before-saving
branch
3 times, most recently
from
52032ae to
e9d767a
Compare
framitdavid
requested changes
Dec 11, 2023
...p-development/features/dataModelling/SchemaEditorWithToolbar/SchemaGenerationErrorsPanel.tsx
Outdated
Show resolved
Hide resolved
...p-development/features/dataModelling/SchemaEditorWithToolbar/SchemaGenerationErrorsPanel.tsx
Outdated
Show resolved
Hide resolved
...p-development/features/dataModelling/SchemaEditorWithToolbar/SchemaGenerationErrorsPanel.tsx
Outdated
Show resolved
Hide resolved
...p-development/features/dataModelling/SchemaEditorWithToolbar/SchemaGenerationErrorsPanel.tsx
Outdated
Show resolved
Hide resolved
...p-development/features/dataModelling/SchemaEditorWithToolbar/SchemaGenerationErrorsPanel.tsx
Show resolved
Hide resolved
...p-development/features/dataModelling/SchemaEditorWithToolbar/SchemaGenerationErrorsPanel.tsx
Outdated
Show resolved
Hide resolved
...p-development/features/dataModelling/SchemaEditorWithToolbar/SchemaGenerationErrorsPanel.tsx
Outdated
Show resolved
Hide resolved
...velopment/features/dataModelling/SchemaEditorWithToolbar/TopToolbar/GenerateModelsButton.tsx
Outdated
Show resolved
Hide resolved
...velopment/features/dataModelling/SchemaEditorWithToolbar/TopToolbar/GenerateModelsButton.tsx
Outdated
Show resolved
Hide resolved
...velopment/features/dataModelling/SchemaEditorWithToolbar/TopToolbar/GenerateModelsButton.tsx
Outdated
Show resolved
Hide resolved
standeren
force-pushed
the
11461-try-to-compile-c-model-before-saving
branch
2 times, most recently
from
becb883 to
1ae3d92
Compare
standeren
force-pushed
the
11461-try-to-compile-c-model-before-saving
branch
from
1ae3d92 to
4a35fd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Do compilation of csharp datamodell when clicking generate model and return customErrorMessages if there are any. If frontend receives any custom error messages it lists them in a new errors panel component.
Example when generating a datamodel with a field having the same name as the model itself and with a type named the same as one of its inner fields:
Related Issue(s)
Verification