Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11809 fix size for text and icon in binding datamodell #11818

Merged

Conversation

JamalAlabdullah
Copy link
Contributor

@JamalAlabdullah JamalAlabdullah commented Dec 7, 2023

Description

  • Fixed size for text and icon in binding datamodel

Related Issue(s)

Verification

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@JamalAlabdullah JamalAlabdullah linked an issue Dec 7, 2023 that may be closed by this pull request
@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Dec 7, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ecbbd7f) 84.85% compared to head (4a8ab31) 84.85%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11818   +/-   ##
=======================================
  Coverage   84.85%   84.85%           
=======================================
  Files         886      886           
  Lines       13053    13053           
  Branches     1661     1661           
=======================================
  Hits        11076    11076           
  Misses       1739     1739           
  Partials      238      238           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlqn mlqn self-requested a review December 8, 2023 12:25
Copy link
Contributor

@mlqn mlqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text looks a bit small compared to the other texts:
text

I wonder if we should make it larger, as in the sketches all the text seems to be the same size:
Frame 2911

@JamalAlabdullah
Copy link
Contributor Author

JamalAlabdullah commented Dec 8, 2023

The text looks a bit small compared to the other texts: text

I wonder if we should make it larger, as in the sketches all the text seems to be the same size: Frame 2911

I changed it from small to 0.875rem where we use this value in many places, I am not sure but maybe because its a linked text should be a litle bit smaller than the others, anyway check and say if we need more in size 😊

@JamalAlabdullah JamalAlabdullah requested a review from mlqn December 8, 2023 14:24
Copy link
Contributor

@mlqn mlqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it with font-size: 0.875rem, but it still looks smaller than the other texts:

Screenshot 2023-12-11 at 10 35 30

I don't think we need to specify the font-size for this text. If we remove it, it will be the same size as the other texts. I also suggest setting the height and width of the icon using the --fds-sizing-4 variable, which is used by the icons in design system.

Screenshot 2023-12-11 at 10 39 47

@JamalAlabdullah JamalAlabdullah requested a review from mlqn December 11, 2023 16:10
Copy link
Contributor

@mlqn mlqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@JamalAlabdullah JamalAlabdullah merged commit 633adb0 into master Dec 12, 2023
9 checks passed
@JamalAlabdullah JamalAlabdullah deleted the 11809-fix-size-for-text-and-icon-in-binding-datamodell branch December 12, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the size for text and icon in binding datamodell
2 participants