-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
11809 fix size for text and icon in binding datamodell #11818
11809 fix size for text and icon in binding datamodell #11818
Conversation
…text-and-icon-in-binding-datamodell
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #11818 +/- ##
=======================================
Coverage 84.85% 84.85%
=======================================
Files 886 886
Lines 13053 13053
Branches 1661 1661
=======================================
Hits 11076 11076
Misses 1739 1739
Partials 238 238 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…text-and-icon-in-binding-datamodell
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it with font-size: 0.875rem
, but it still looks smaller than the other texts:
I don't think we need to specify the font-size
for this text. If we remove it, it will be the same size as the other texts. I also suggest setting the height and width of the icon using the --fds-sizing-4
variable, which is used by the icons in design system.
frontend/packages/ux-editor/src/components/config/editModal/EditDataModelBindings.module.css
Outdated
Show resolved
Hide resolved
frontend/packages/ux-editor/src/components/config/editModal/EditDataModelBindings.module.css
Outdated
Show resolved
Hide resolved
…text-and-icon-in-binding-datamodell
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Description
Related Issue(s)
Verification
Documentation