-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing test feedback #12295
fixing test feedback #12295
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12295 +/- ##
=======================================
Coverage 86.42% 86.43%
=======================================
Files 1198 1198
Lines 18068 18080 +12
Branches 2292 2295 +3
=======================================
+ Hits 15616 15628 +12
+ Misses 2167 2166 -1
- Partials 285 286 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I tested this locally and it looks much better now 🥳
EDIT: I just noticed something that I did not notice when I first tested this! I see that the heading at the top of the section reflects the text resource binding for the component, rather than the component type.
The heading should always show the component type. F.ex. in the example here:
I would expect Radioknapper
(component type) at (1) instead of the component title text. While at (2) I do expect the title text. And (3) can then be removed.
The changes in this PR are related to the comments from the testing and look good, so I have approved them, let me know if you plan to make these changes to this PR and I can review again, or you can create a new PR if that's easier for you 😊
@nkylstad, I've fixed the header now 😄 |
Description
Related Issue(s)
Verification