Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing test feedback #12295

Merged
5 commits merged into from
Feb 13, 2024
Merged

fixing test feedback #12295

5 commits merged into from
Feb 13, 2024

Conversation

ghost
Copy link

@ghost ghost commented Feb 12, 2024

Description

  • Fixing feedback mentioned in the issue while testing. It now looks like this:
Skjermbilde 2024-02-12 kl  22 00 47

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@ghost ghost linked an issue Feb 12, 2024 that may be closed by this pull request
@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Feb 12, 2024
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (92f54ae) 86.42% compared to head (8009e7a) 86.43%.

❗ Current head 8009e7a differs from pull request most recent head cb89f37. Consider uploading reports for the commit cb89f37 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12295   +/-   ##
=======================================
  Coverage   86.42%   86.43%           
=======================================
  Files        1198     1198           
  Lines       18068    18080   +12     
  Branches     2292     2295    +3     
=======================================
+ Hits        15616    15628   +12     
+ Misses       2167     2166    -1     
- Partials      285      286    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nkylstad nkylstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I tested this locally and it looks much better now 🥳

EDIT: I just noticed something that I did not notice when I first tested this! I see that the heading at the top of the section reflects the text resource binding for the component, rather than the component type.
The heading should always show the component type. F.ex. in the example here:
Screenshot 2024-02-13 at 08 24 27
I would expect Radioknapper (component type) at (1) instead of the component title text. While at (2) I do expect the title text. And (3) can then be removed.

The changes in this PR are related to the comments from the testing and look good, so I have approved them, let me know if you plan to make these changes to this PR and I can review again, or you can create a new PR if that's easier for you 😊

@ghost
Copy link
Author

ghost commented Feb 13, 2024

@nkylstad, I've fixed the header now 😄
image

@ghost ghost merged commit f49f528 into main Feb 13, 2024
9 checks passed
@ghost ghost deleted the 12180-fix-feedback-default-config-section branch February 13, 2024 09:44
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create the default section for component config
3 participants