Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: designer cd #13466

Merged
merged 5 commits into from
Sep 10, 2024
Merged

feat: designer cd #13466

merged 5 commits into from
Sep 10, 2024

Conversation

mirkoSekulic
Copy link
Collaborator

@mirkoSekulic mirkoSekulic commented Sep 4, 2024 •
edited
Loading

Description

Pr enables continuous delivery of the designer service.
preapproved-prod environment is used instead of prod.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added the skip-releasenotes Issues that do not make sense to list in our release notes label Sep 4, 2024
@mirkoSekulic mirkoSekulic marked this pull request as draft September 4, 2024 07:04
@mirkoSekulic mirkoSekulic marked this pull request as ready for review September 10, 2024 09:00
framitdavid
framitdavid approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@framitdavid framitdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 🚀

@codecov Codecov
Copy link

codecov bot commented Sep 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.99%. Comparing base (7dc2ba0) to head (26a1f35).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #13466   +/-   ##
=======================================
  Coverage   93.99%   93.99%           
=======================================
  Files        1456     1456           
  Lines       20110    20110           
  Branches     2438     2438           
=======================================
  Hits        18902    18902           
  Misses        954      954           
  Partials      254      254

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mirkoSekulic mirkoSekulic merged commit 5aa83e3 into main Sep 10, 2024
16 checks passed
@mirkoSekulic mirkoSekulic deleted the feature/designer-cd branch September 10, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@framitdavid framitdavid framitdavid approved these changes

@mlqn mlqn mlqn approved these changes

Assignees
No one assigned
Labels
skip-releasenotes Issues that do not make sense to list in our release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mirkoSekulic @mlqn @framitdavid