-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor SchemaModelService to update appMetadata when creating new data model #14209
feat: refactor SchemaModelService to update appMetadata when creating new data model #14209
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ingenting å utsette på dette så vidt jeg kan se. Fin og utfyllende beskrivelse!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test OK 🚀
…data-on-create-new-model
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14209 +/- ##
=======================================
Coverage 95.52% 95.52%
=======================================
Files 1826 1826
Lines 23757 23757
Branches 2752 2752
=======================================
Hits 22695 22695
Misses 807 807
Partials 255 255 ☔ View full report in Codecov by Sentry. |
Description
Refactor SchemaModelService to update appMetadata when creating new data model:
UpdateCSharpClasses
to only update csharp classes and move the logic to get the full type name out in separate methodGetFullTypeName
. Also created a separate function forNamespaceNeedsToBeSeparated
that is now used inUpdateCSharpClasses
.UpdateModelFilesFromJsonSchema
as it was not used.UpdateApplicationMetadata
function fromProcessNewXsd
toBuildSchemaFromXsd
.ProcessNewXsd
toGenerateJsonSchemaAndCSharp
since that is more concrete.UpdateApplicationMetadata
function inCreateSchemaFromTemplate
.SerializeModelMetadata
since it was not used.In addition I changed the name of fileName in the
BuildSchemaFromXsd
, which is called when uploading xsd, tofileNameWithExtension
to make a clearer what variables of the name that has extensions and not.Related Issue(s)
dataModelId
is added toappMetadata
on create new model #14123Verification